WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#19351 closed defect (bug) (fixed)

The 'appearance' Admin Bar Group Has No .ab-sub-secondary Styling?

Reported by: markmcwilliams Owned by: ryan
Milestone: 3.3 Priority: normal
Severity: normal Version: 3.3
Component: Toolbar Keywords: has-patch commit dev-reviewed
Focuses: Cc:

Description

As the title suggests, the new 'appearance' group from [19434] and #19245 didn't have any .ab-sub-secondary styling included with it. The was it looks on a live site, would suggest it should have, attached is a before/after picture and a patch!

Attachments (4)

before.png (2.7 KB) - added by markmcwilliams 3 years ago.
after.png (2.7 KB) - added by markmcwilliams 3 years ago.
19351.diff (754 bytes) - added by markmcwilliams 3 years ago.
merge.appearance.group.diff (397 bytes) - added by nacin 3 years ago.
From koopersmith.

Download all attachments as: .zip

Change History (11)

@markmcwilliams3 years ago

@markmcwilliams3 years ago

@markmcwilliams3 years ago

comment:1 @ocean903 years ago

  • Keywords ui-feedback removed
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Yesterday in IRC:

ocean90: Jane_, koopersmith: Should be the background grey for the last 3 links http://cl.ly/C4ww? Seems like nacin forget it.

koopersmith: ocean90: No, that's just group styling.

Jane_: no reason it needs to be gray

koopersmith: ocean90: group != secondary styling

comment:2 @markmcwilliams3 years ago

Oh, that's what happens when you don't hang around IRC with the cool kids. It looks pretty stupid IMHO without some kind of styling, like it's been bolted on cause there "ain't no other place to put it" so to speak, but what's to be shall be! Could we at least remove the horizontal line, or bottom/top border?

comment:3 @ocean903 years ago

  • Cc jane added
  • Keywords ui-feedback added

Could we at least remove the horizontal line, or bottom/top border?

comment:4 @nacin3 years ago

  • Keywords commit added; ui-feedback removed
  • Milestone set to 3.3
  • Resolution wontfix deleted
  • Status changed from closed to reopened

Per Jane, the line should go.

@nacin3 years ago

From koopersmith.

comment:5 @ryan3 years ago

Okay.

comment:6 @nacin3 years ago

  • Keywords dev-reviewed added

comment:7 @ryan3 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from reopened to closed

In [19550]:

Remove separator from appearance group. Props koopersmith. fixes #19351

Note: See TracTickets for help on using tickets.