Pointers misplaced when object is hidden

[markoheijnen]

I got a small issue with the new pointers (media upload pointer). It was hiding behind the admin bar since I had the editor hidden trough CSS. Probably a case that is not likely to see for a lot of users

[scribu]

You can hide the editor by modifying the 'supports' parameter of the post type.

I suggest closing as 'worksforme', unless there's potential to make the pointer JS more robust.

[markoheijnen]

I do need it on the edit page but only when a tab is selected. This due some possible large meta_boxes.
The reason I post it as a bug is due the possibility that in other rare cases this can happen.

[jane]

I vote with @scribu.

[CoenJacobs]

Replying to scribu:

You can hide the editor by modifying the 'supports' parameter of the post type.

Not valid if you want to hide it temporarily. I can imagine some kind of 'wizard like' (been there, done that) way of creating pages, where you only want to show the editor after entering the title. The editor won't be visible at page load, so the pointer can't be placed at the correct position. Simple as pie: If the target object is not there, the pointer shouldn't be placed.

[scribu]

Yes, except in this case, the DOM element is there, but it's hidden.

[CoenJacobs]

Replying to scribu:

Yes, except in this case, the DOM element is there, but it's hidden.

Correct, but it doesn't make sense to show a pointer at a hidden element. Look at it from an user perspective, seeing pointers where the element is hidden, doesn't make sense. I agree that it isn't easy to fix and not a lot of users will have to face it, but problem lies in the base of the way pointers work.

[nacin]

I agree with Coen. We should simply ensure that a pointer's target element is visible first.

[nacin]

In [19467]:

Don't open a pointer when the target element is hidden. see #19357.

[koopersmith]

In [19482]:

Don't open a pointer when the target element is hidden. fixes #19357.

[koopersmith]

Just tweaked the logic slightly and added a check to _open as well.