WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 7 years ago

#1936 closed defect (bug) (fixed)

Ugly bland error message upon missing wp-config file ... and a fix!

Reported by: chuyskywalker Owned by: markjaquith
Milestone: 2.1 Priority: normal
Severity: normal Version: 1.6
Component: Administration Keywords: has-patch commit
Focuses: Cc:

Description

I was going through the 2.0 beta1 to give it a run and after SNV CO'ing the files I just hit the website and got this ugly, no frills, plain, and scary error message about some missing files and some such.

So, doing my part, here's a patch that snatches the same layout as the database error screen and uses it to pretty up this error. Additionally, I added some basic write checks to see if a user can even use the setup-config.php before offering them the false hope that it'd work.

Finally, I've updated the "more help" link to point to the much more complete and helpful codex wp-config reference.

Attachments (4)

nicer-no-config.diff (2.6 KB) - added by chuyskywalker 8 years ago.
patch to make the ugly error not so ugly, and much more helpful
1936.diff (2.5 KB) - added by Nazgul 8 years ago.
missing_wp-config.patch (2.4 KB) - added by Viper007Bond 7 years ago.
missing_wp-config.2.patch (2.4 KB) - added by Viper007Bond 7 years ago.

Download all attachments as: .zip

Change History (16)

chuyskywalker8 years ago

patch to make the ugly error not so ugly, and much more helpful

comment:1 chuyskywalker8 years ago

  • Keywords bg|has-patch added

comment:2 matt8 years ago

  • Milestone changed from 2.0 to 2.1

Nazgul8 years ago

comment:3 Nazgul8 years ago

  • Keywords has-patch added; bg|has-patch removed

Updated the patch to make use of wp_die.

comment:4 Nazgul8 years ago

  • Milestone changed from 2.1 to 2.0.5

2.0.5. Candidate

comment:5 markjaquith8 years ago

  • Milestone changed from 2.0.5 to 2.1
  • Owner changed from anonymous to markjaquith
  • Status changed from new to assigned

wp_die() is 2.1 only.

comment:6 markjaquith8 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [4307]) missing wp-config.php error uses wp_die() now. props Nazgul. fixes #1936

comment:7 Viper007Bond7 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Needs some more work.

comment:8 Viper007Bond7 years ago

Bah, forgot to check the "overwrite" box.

comment:9 matt7 years ago

  • Milestone changed from 2.1 to 2.2

comment:10 follow-up: Viper007Bond7 years ago

Why is changing the help link to the Codex something that should wait for 2.2?

comment:11 in reply to: ↑ 10 foolswisdom7 years ago

  • Keywords commit added
  • Milestone changed from 2.2 to 2.1

Replying to Viper007Bond:

Why is changing the help link to the Codex something that should wait for 2.2?

Because this ticket has become epic? ;-) But lets try again. Setting milestone to 2.1 . Please apply missing_wp-config.2.patch

epic: started out with a detailed problem and creative and complete solution by chuyskywalker, later Nazgul lay down a tight fix... time passed... Viper reopened for the missing important pieces, but the tale was probably forgotten. I often do the same thing, but I do try to remember that we have lots of ticket numbers available.

comment:12 ryan7 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [4737]) Change editing wp-config codex link. fixes #1936

Note: See TracTickets for help on using tickets.