WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#19364 closed enhancement (fixed)

Mark http://wordpress.org URL for translation

Reported by: zeo Owned by: nacin
Milestone: 3.4 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: Cc:
PR Number:

Description

  • Remove the trailing slash to match the same string in wp-includes/admin-bar.php#L96
  • Remove unnecessary <span class="hide">...</span>
  • Minor cleanup

Feel free to tweak the original patch

Attachments (1)

19364.diff (1.4 KB) - added by zeo 8 years ago.

Download all attachments as: .zip

Change History (6)

@zeo
8 years ago

#1 follow-up: @nacin
8 years ago

  • Type changed from defect (bug) to enhancement

Seems fine. Do we translate "http://wordpress.org/" anywhere else yet?

#2 in reply to: ↑ 1 @Zeo
8 years ago

Replying to nacin:

Do we translate "http://wordpress.org/" anywhere else yet?

None in core and MS POT. That's why I remove the trailing slash in the patch.

But "http://wordpress.org/" is currently used in http://core.trac.wordpress.org/browser/trunk/wp-content/themes/twentyten/footer.php#L33 and http://core.trac.wordpress.org/browser/trunk/wp-content/themes/twentyeleven/footer.php#L27

Not sure whether we should stick with or without /

#3 @nacin
8 years ago

I just opened #19427 to handle "http://wordpress.org/" being translated properly.

We can run with this for 3.4.

#4 @nacin
8 years ago

  • Milestone changed from Awaiting Review to 3.4
  • Owner set to nacin
  • Status changed from new to accepted

#5 @nacin
8 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In [19783]:

Translate http://wordpress.org/ for the wp-login.php header image URL. Clean up. props zeo, fixes #19364.

Note: See TracTickets for help on using tickets.