WordPress.org

Make WordPress Core

Opened 2 years ago

Last modified 14 months ago

#19365 new enhancement

Pages listed under Most Recent and Search tabs of Page meta box in Appearance -> Menus should be filterable

Reported by: onokazu Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 3.2.1
Component: Menus Keywords: has-patch
Focuses: Cc:

Description

On the Appearance -> Menus administration page, pages listed under the Most Recent and Search tabs of the Page meta box on the left are not filterable. Since the pages listed under the View All tab of the said metabox are already filterable via the nav_menu_items_page hook, why not do the same for these 2 tabs?

I have a plugin that generates a number of pages that are accessible by registered users only, and I do not want administrators to be able to put these pages on the menu in any way.

Attachments (1)

19365.diff (598 bytes) - added by jpyper 14 months ago.
Add one line with an apply_filters for altering posts passed into the Most Recent tab, just like is already done for the View All tab.

Download all attachments as: .zip

Change History (7)

comment:1 jpyper14 months ago

  • Cc jarrod@… added

I'm looking to do the same thing and wondered why those other two tabs were not filterable. It would be a simple addition, 2 extra lines.

I don't think this counts as a bug though, probably more fitting as an Enhancement. I wonder what we can do to get this any attention. Did you find a way around this seeing as you opened the ticket 15 months ago?

Version 0, edited 14 months ago by jpyper (next)

jpyper14 months ago

Add one line with an apply_filters for altering posts passed into the Most Recent tab, just like is already done for the View All tab.

comment:2 follow-up: jpyper14 months ago

  • Keywords has-patch added

patch added. This takes care of the Most Recent tab but doesn't do a thing about Search. This is "good enough" for my needs and I think would be a logical addition to core since the same filtering happens for View All.

comment:3 SergeyBiryukov14 months ago

  • Component changed from Administration to Menus
  • Type changed from defect (bug) to enhancement

comment:4 in reply to: ↑ 2 ; follow-up: DrewAPicture14 months ago

Replying to jpyper:

patch added. This takes care of the Most Recent tab but doesn't do a thing about Search. This is "good enough" for my needs and I think would be a logical addition to core since the same filtering happens for View All.

Please regenerate your patch from the WordPress install root.

Also, in staying consistent with coding standards and common variable hook naming-conventions, I suggest something more like this:

$most_recent = apply_filters( 'nav_menu_recent_{$post_type_name}_items', $most_recent );

comment:5 in reply to: ↑ 4 ; follow-up: jpyper14 months ago

Drew, I took your advice on the naming convention, but I don't know what you mean about regenerating from the WP install root. It took me embarrassingly long to figure out how to make the diff file in the first place...

comment:6 in reply to: ↑ 5 DrewAPicture14 months ago

Replying to jpyper:

Drew, I took your advice on the naming convention, but I don't know what you mean about regenerating from the WP install root. It took me embarrassingly long to figure out how to make the diff file in the first place...

If you look at 19365.diff, notice the path in bold at the top: /Users/jarrodpyper/Downloads/wordpress/wp-admin/includes/

You want to be generating the patch/diff from the /wordpress/ directory instead.

If you need further help, check out Submitting a patch in the handbook or visit the #wordpress-contribute IRC channel on Freenode and somebody can give you more help.

Note: See TracTickets for help on using tickets.