WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 22 months ago

Last modified 22 months ago

#19381 closed defect (bug) (wontfix)

PHP [E_STRICT] is_a(): Deprecated. Please use the instanceof operator in

Reported by: arena Owned by:
Milestone: Priority: normal
Severity: trivial Version: 3.3
Component: Warnings/Notices Keywords: close
Focuses: Cc:

Description

PHP [E_STRICT] 2048 : is_a(): Deprecated. Please use the instanceof operator in

    /wp-admin/includes/template.php -> line 95
    /wp-includes/general-template.php -> line 2087
    /wp-admin/includes/screen.php -> line 387
    /wp-includes/user.php -> line 74
    /wp-includes/user.php -> line 122
    /wp-includes/functions.wp-styles.php -> line 26
    /wp-includes/functions.wp-styles.php -> line 53
    /wp-includes/functions.wp-styles.php -> line 81
    /wp-includes/functions.wp-styles.php -> line 102
    /wp-includes/functions.wp-styles.php -> line 133
    /wp-includes/functions.wp-styles.php -> line 155
    /wp-includes/functions.wp-styles.php -> line 179
    /wp-includes/widgets.php -> line 1126
    /wp-includes/class-feed.php -> line 30
    /wp-includes/class-simplepie.php -> line 847
    /wp-includes/class-simplepie.php -> line 1637
    /wp-includes/class-simplepie.php -> line 3068
    /wp-includes/class-simplepie.php -> line 8658
    /wp-includes/class-simplepie.php -> line 8880
    /wp-includes/compat.php -> line 68
    /wp-includes/compat.php -> line 81
    /wp-includes/class-IXR.php -> line 85
    /wp-includes/class-IXR.php -> line 88
    /wp-includes/class-IXR.php -> line 394
    /wp-includes/class-IXR.php -> line 534
    /wp-includes/class-IXR.php -> line 972
    /wp-includes/pluggable.php -> line 213
    /wp-admin/includes/class-wp-users-list-table.php -> line 220
    /wp-includes/script-loader.php -> line 575
    /wp-includes/script-loader.php -> line 597
    /wp-includes/script-loader.php -> line 654
    /wp-includes/script-loader.php -> line 699
    /wp-includes/script-loader.php -> line 725
    /wp-includes/functions.wp-scripts.php -> line 27
    /wp-includes/functions.wp-scripts.php -> line 54
    /wp-includes/functions.wp-scripts.php -> line 88
    /wp-includes/functions.wp-scripts.php -> line 110
    /wp-includes/functions.wp-scripts.php -> line 128
    /wp-includes/functions.wp-scripts.php -> line 148
    /wp-includes/functions.wp-scripts.php -> line 172
    /wp-includes/functions.wp-scripts.php -> line 196
    /wp-includes/Text/Diff.php -> line 77
    /wp-includes/Text/Diff.php -> line 78
    /wp-includes/Text/Diff.php -> line 96
    /wp-includes/Text/Diff.php -> line 97
    /wp-includes/Text/Diff.php -> line 140
    /wp-includes/Text/Diff.php -> line 158
    /wp-includes/deprecated.php -> line 2685
    /wp-includes/Text/Diff/Renderer.php -> line 86
    /wp-includes/category-template.php -> line 743
    /wp-includes/category-template.php -> line 761
    /wp-includes/class-wp-error.php -> line 207

Change History (10)

comment:1 follow-up: scribu2 years ago

  • Component changed from General to Warnings/Notices
  • Keywords reporter-feedback removed
  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed
  • Type changed from task (blessed) to defect (bug)
  1. Only lead devs can define blessed tasks.
  1. If you're the reporter, you don't set the reporter-feedback keyword. You probably meant developer-feedback.
  1. is_a() has been un-deprecated in PHP 5.3: http://php.net/is_a
Last edited 2 years ago by scribu (previous) (diff)

comment:2 in reply to: ↑ 1 ericlewis22 months ago

  • Resolution invalid deleted
  • Status changed from closed to reopened

Replying to scribu:

  1. is_a() has been un-deprecated in PHP 5.3: http://php.net/is_a

Most server environments don't run 5.3, I recently heard a quote of 10% of servers are actually running 5.3. Since it is deprecated in 5.2.x, that means most people (90%?) would see the strict standards warning, if they had such high level error reporting turned on.

I'm reopening, suggesting the fix as suggested by arena, which will hide any strict standards warnings that may pop up.

comment:3 scribu22 months ago

  • Keywords 2nd-opinion needs-patch added
  • Milestone set to Awaiting Review

Most server environments don't run 5.3

Most server environments don't have E_STRICT turned on either and I would wager that the combination of servers running PHP 5.2 AND having E_STRICT on is vanishingly small.

Version 0, edited 22 months ago by scribu (next)

comment:4 follow-up: scribu22 months ago

Because if you care about E_STRICT, but haven't bothered to update to a version of PHP that still receives security updates, your priorities are all wrong.

Last edited 22 months ago by scribu (previous) (diff)

comment:5 in reply to: ↑ 4 ericlewis22 months ago

Replying to scribu:

Because if you care about E_STRICT, but haven't bothered to update to a version of PHP that still receives security updates, your priorities are all wrong.

True, this is probably a narrow use case.

Also of note, I just noticed E_STRICT is included in E_ALL as of 5.4 (see note next to E_STRICT in PHP Error Constants), so there would be an added bonus to the also potentially narrow use case of anyone running 5.4 with WP_DEBUG set to true.

comment:6 follow-up: scribu22 months ago

There would be no bonus, since is_a() is not deprecated in PHP 5.4 either.

comment:7 in reply to: ↑ 6 ericlewis22 months ago

Replying to scribu:

There would be no bonus, since is_a() is not deprecated in PHP 5.4 either.

Heh, whoops. Yep, no bonus.

comment:8 scribu22 months ago

So, can I close this again? There are so many other, more useful, tickets that need attention.

comment:9 ericlewis22 months ago

  • Keywords close added; 2nd-opinion needs-patch removed
  • Resolution set to wontfix
  • Status changed from reopened to closed

Sure.

comment:10 SergeyBiryukov22 months ago

  • Milestone Awaiting Review deleted
Note: See TracTickets for help on using tickets.