WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#19382 closed defect (bug) (fixed)

Before RC3/release: Uncomment add_action() call to hide pointers for new users

Reported by: nacin Owned by: nacin
Milestone: 3.3 Priority: normal
Severity: normal Version: 3.3
Component: Administration Keywords: tracking-ticket has-patch commit
Focuses: Cc:

Description

Before the final 3.3 release, the get_site_option() call in WP_Internal_Pointers::enqueue_scripts() should have the db version of 20000 updated to the final $wp_db_version.

This code ensures that all 3.3 users will only see the pointers for installs upgraded from a previous release.

By not doing this now (see [19466]) we ensure that all 3.3 testers, even when creating a scratch 3.3 install, will see the pointers.

Attachments (1)

19382.diff (703 bytes) - added by nacin 4 years ago.
Do not commit me before RC2/release.

Download all attachments as: .zip

Change History (8)

comment:1 @nacin4 years ago

Per #19360 this might evolve into uncommenting an add_action() call.

comment:2 @nacin4 years ago

In [19490]:

Allow scratch beta/RC installs to experience pointers. Uncomment this before release. see #19360, #19382.

comment:3 @nacin4 years ago

  • Keywords has-patch commit added

Do not commit before RC2/release.

@nacin4 years ago

Do not commit me before RC2/release.

comment:4 @nacin4 years ago

  • Summary changed from Bump final 3.3 DB version for pointers to Before RC2/release: Uncomment add_action() call to hide pointers for new users

comment:5 @johnbillion4 years ago

Gentle reminder on this as we're now on RC2.

comment:6 @nacin4 years ago

  • Summary changed from Before RC2/release: Uncomment add_action() call to hide pointers for new users to Before RC3/release: Uncomment add_action() call to hide pointers for new users

We'll probably do a soft RC3 that ends up being the package to go gold. That would be a good time to include this.

comment:7 @nacin4 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [19574]:

Don't show new feature pointers for new installs and users. fixes #19382.

Note: See TracTickets for help on using tickets.