Opened 13 years ago
Closed 13 years ago
#19385 closed defect (bug) (fixed)
wp_get_active_network_plugins() can generate a needless query
Reported by: | nacin | Owned by: | ryan |
---|---|---|---|
Milestone: | 3.3 | Priority: | normal |
Severity: | normal | Version: | 3.3 |
Component: | Multisite | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
In #18955, we stopped caching the default value when get_site_option() was called on an option that does not exist.
This introduces a situation where active_sitewide_plugins may be queried for on every pageload.
- active_sitewide_plugins should be instantiated in populate_network() and added to upgrade_network().
- wp_load_core_site_options() should be set up to cache as false any keys it misses. As this only works when an external object cache is not at play, it basically becomes a rudimentary not-options cache. (See #19008.)
Point 1 is for 3.3. Point 2 is a general nice-to-have.
Attachments (2)
Change History (5)
Note: See
TracTickets for help on using
tickets.
Handles point 1.