WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#19408 closed defect (bug) (fixed)

Dashboard Welcome "Customize Your Site" w/ no background, header theme support

Reported by: Zeo Owned by: ryan
Milestone: 3.3 Priority: normal
Severity: normal Version: 3.3
Component: Administration Keywords: has-patch commit
Focuses: Cc:

Description

If current theme has no widget, custom background and header support it should display a different info under "Customize Your Site"

Attachments (2)

Dashboard Welcome.png (22.0 KB) - added by Zeo 3 years ago.
19408.diff (3.1 KB) - added by ryan 3 years ago.

Download all attachments as: .zip

Change History (16)

@Zeo3 years ago

comment:1 @jane3 years ago

  • Milestone changed from Awaiting Review to 3.3
  • Version set to 3.3

The dashboard welcome is only supposed to show info about the bundled default theme, not update with themes as they get changed around.

comment:2 @nacin3 years ago

I think it was coded this way because Twenty Eleven may not be the default theme in a multisite environment. Easy to adjust, but I think it should leverage the internal default theme, rather than "Twenty Eleven." (Currently, it relies on the current theme, which I agree is ehh.)

comment:3 follow-up: @jane3 years ago

@nacin: I thought it had been decided not to even show the welcome on new sites in a multisite install?

comment:4 in reply to: ↑ 3 @nacin3 years ago

Replying to jane:

@nacin: I thought it had been decided not to even show the welcome on new sites in a multisite install?

The decision was that the welcome would be shown to the owner of the site in a multisite install, if the owner has never seen the welcome screen before on any other site.

Sidenote on implementation, the more I look at the language, the more I realize it is reliant on the current theme being the default theme. I'm catching some rest and will work with ryan on this in the morning to nail down the desired behavior.

@ryan3 years ago

comment:5 @ryan3 years ago

This code handles lots of edge cases. Broken current theme, no themes at all, WP_DEFAULT_THEME is not twentyeleven, a custom installer set the default theme to something other than twentyeleven, current theme does not have certain capabilities, current theme is not the default theme, and probably a few other things we haven't thought about. And with 19408.diff it handles the theme not having any known customization screens.

comment:6 @nacin3 years ago

I'm fine with 19408.diff though it reads weird when there is only one customization screen.

comment:7 @nacin3 years ago

  • Keywords has-patch added

comment:8 @Zeo3 years ago

Patch is good.

I think if there's only one theme installed, don't show the whole column or add another condition with "Use the current theme &mdash; %1$s &mdash; or <a href="%2$s">Install a new theme</a>.".

That of course is a very rare case.

comment:9 @ryan3 years ago

Tested with Twenty Eleven, Twenty Ten, empty themes directory, broken current theme, and a mix of themes from the theme directory. The language when there is only one customization screen is indeed odd but good enough for now.

comment:10 @nacin3 years ago

  • Keywords commit added

Fine with that.

comment:11 @Zeo3 years ago

in 19408.diff, perhaps use:

  • Choose light or dark color scheme
  • Set a background image or color

comment:12 @nacin3 years ago

  • Keywords i18n-change added

comment:13 @ryan3 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [19545]:

Handle themes that have no customization screens. fixes #19408

comment:14 @nacin3 years ago

  • Keywords i18n-change removed

Leaving the changes suggested by zeo for a later time.

Removing i18n-change since we're freezing strings now.

Note: See TracTickets for help on using tickets.