WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#19410 closed defect (bug) (fixed)

"New" in + New icon on Admin Bar is black on focus

Reported by: linuxologos Owned by: nacin
Milestone: 3.3 Priority: normal
Severity: normal Version: 3.3
Component: Toolbar Keywords: has-patch commit
Focuses: Cc:

Description

Related to: #19404

The text is black and hidden on :focus.

Attachments (2)

19410.patch (577 bytes) - added by linuxologos 2 years ago.
19410.2.diff (394 bytes) - added by koopersmith 2 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 jane2 years ago

  • Keywords reporter-feedback added
  • Milestone changed from Awaiting Review to 3.3

@linuxlogos: What browser/OS are you using?

linuxologos2 years ago

comment:2 linuxologos2 years ago

  • Keywords has-patch added; needs-patch reporter-feedback removed

I can see that with IE/Firefox/Chrome (latest versions) on Windows 7 with latest trunk. I can test on Linux too, if necessary.

19410.patch fixes the problem for me, but I'm not sure if it's good CSS.

koopersmith2 years ago

comment:3 follow-up: koopersmith2 years ago

  • Keywords needs-testing added

Confirmed — you have to click (and hold) the "New" item on the front-end to notice the bug. It's important that we only fix this for when jQuery is disabled, as the focus styles differ.

attachment:19410.2.diff addresses this issue and the simplest selector in the correct place.

comment:4 nacin2 years ago

  • Keywords commit added; needs-testing removed

I can confirm the bug. Not completely read up on the selectors, but 19410.2.diff looks good.

Last edited 2 years ago by nacin (previous) (diff)

comment:5 nacin2 years ago

Okay, I'm now read up. +1.

comment:6 in reply to: ↑ 3 linuxologos2 years ago

Replying to koopersmith:

Confirmed — you have to click (and hold) the "New" item on the front-end to notice the bug. It's important that we only fix this for when jQuery is disabled, as the focus styles differ.

Yes, I was at the front-end with TwentyEleven, where jQuery in not enabled by default.

19410.2.diff works fine.

Version 0, edited 2 years ago by linuxologos (next)

comment:7 ryan2 years ago

Looks good.

comment:8 nacin2 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [19540]:

Admin bar styling: Ensure text next to icon stays visible on focus when jQuery is not loaded. props koopersmith, linuxologos, fixes #19410.

Note: See TracTickets for help on using tickets.