WordPress.org
Get WordPress

Make WordPress Core

Opened 13 years ago

Closed 13 years ago

#19416 closed defect (bug) (fixed)

Editors 'Site Menu' broken on the front end

Reported by: ipstenu's profile Ipstenu Owned by: koopersmith's profile koopersmith
Milestone: 3.3 Priority: normal
Severity: critical Version: 3.3
Component: Toolbar Keywords: has-patch commit
Focuses: Cc:

Description

As an admin there are no problems. Everything looks fine on the site menu in the toolbar

http://f.cl.ly/items/0L3U2d1d251w1T1K0A3o/as-admin.jpg

If I log in as an EDITOR however:

http://f.cl.ly/items/0n2S2d2k3j280k2J190G/as-editor.jpg

Which is:

Warning: Invalid argument supplied for foreach() in /home/ipstenu/public_html/wp-includes/class-wp-admin-bar.php on line 245

I can reproduce this on a single-site RC1 install and a SVN Multisite.

Attachments (2)

19416.diff​ (10.0 KB) - added by koopersmith 13 years ago.
19416.2.diff​ (10.3 KB) - added by koopersmith 13 years ago.

Download all attachments as: .zip

Change History (10)

#1 @nacin
13 years ago

  • Milestone changed from Awaiting Review to 3.3

Interesting. This is the result of lazy-binding the children arg.

#2 @nacin
13 years ago

  • Owner set to koopersmith
  • Status changed from new to assigned

@koopersmith
13 years ago

#3 @koopersmith
13 years ago

  • Keywords has-patch added
  • Status changed from assigned to accepted

​19416.diff centralizes how things are bound, initialized, and set, finishing what [19501] started. Fixes #19371 as well as this ticket.

#4 @nacin
13 years ago

  • Keywords commit added

Worked on this with koopersmith. Tested, looks good.

#5 @DrewAPicture
13 years ago

#19423 closed as duplicate.

#6 @ryan
13 years ago

Okay.

@koopersmith
13 years ago

#7 @koopersmith
13 years ago

Patch updated to account for [19548].

#8 @ryan
13 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In [19558]:

Admin bar API improvements. Props koopersmith. fixes #19416 #19371

Note: See TracTickets for help on using tickets.