Lower priorities on toolbar search and my account actions.

[koopersmith]

In [19518], we altered the priorities of the search and my account toolbar actions. Some plugins may have been adding items to the my account menu at earlier priorities, which pushes the user info and log out links down in the my account menu.

Given the significance of these links, I would suggest shifting both search and my account to priority 0.

[koopersmith]

Thinking this over, we only really care about the positioning of the submenu items within the my account menu. I suggest we use one function to add the my account submenu items (bound to priority 0), and two others to add the top level search and my account items.

[nacin]

Agree we have to do something here.

I had suggested 0 but now I'm wondering if 1 & 2 might make sense, in case a plugin has a particular use case. For example, a top-level "Log Out" button.

The main worry here is the submenu items, rather than the top-level items. Let's split the my-account submenu items into a separate function and make them priority 0, then stagger search and my-account at 2 and 4, respectively.

[nacin]

While looking into the history of this I found #19425.

[nacin]

19425.2.diff​ is clever, but see #19429.

[koopersmith]

Okay, so attachment:19425.2.diff​ is probably a little too sneaky. Try this one on for size.

[nacin]

19425.3.diff​: Noting that most of these changes are just un-indenting due to if ( ! $user_id ) return;. Yay for returning early.

[nacin]

Note that this will need refresh to work with #19429's renaming of my-account.

[nacin]

Wondering if it would be worth moving user-info, edit-profile, and logout into a user-info-group, but adding logout much later, that way logout is consistently the last link of the first group. Sometimes people may want to add secondary items, other times primary items. It would be better if logout is not so lost.

[koopersmith]

Replying to nacin:

Wondering if it would be worth moving user-info, edit-profile, and logout into a user-info-group, but adding logout much later, that way logout is consistently the last link of the first group. Sometimes people may want to add secondary items, other times primary items. It would be better if logout is not so lost.

I agree, and then some. The user info section has been a perfect example for why we needed groups in the first place, and making it a defined (instead of default) group will keep the account menu more organized as we move forward.

As for a group name, user-actions has a lovely ring to it. :)

[ryan]

Okay.

[koopersmith]

Updated for [19549].

[ryan]

In [19559]:

Introduce user-actions group and move profile and logout menu items to it and change priority. Props koopersmith. fixes #19425