Need to support old admin bar node ID my-account-with-avatar

[nacin]

In 3.2, the my account ID varied from my-account-with-avatar to my-account, depending on whether avatars were enabled. This was moved to classes in 3.3 where it belongs.

Unfortunately plugins may have been using my-account-with-avatar. We need to preserve these mappings.

A quick search of the directory found BuddyPress was among the plugins that did this. And smartly, for that matter -- $bp->my_account_menu_id = ( ! empty( $avatar ) ) ? 'my-account-with-avatar' : 'my-account';.

Patch incoming.

[nacin]

This would revive the mapping concept proposed in #19245. But the binding code is no longer the proper place for it. add_node() it is.

[nacin]

I checked all of the IDs in 3.2 and the only other one is my-blogs to my-sites. Of note, blog-{$id} and blog-{$id}-* still work. BuddyPress and a few other plugins were using my-blogs.

[koopersmith]

Tested. Looks good to me.

[nacin]

Adds period.

[nacin]

Per #19429, we're going to want to map 'my-account' and 'my-account-with-avatar' to 'account'.

[nacin]

Refreshed after #19429.

[nacin]

duck_ has pointed out that the first and third sprintf() arguments need to be reversed.

[ryan]

Okay.

[nacin]

Needs refresh, s/account/my-account/g.

[azaozz]

Looks good.

[ryan]

In [19555]:

Add back compat support for my-account-with-avatar admin bar node id. fixes #19426

[ryan]

In [19556]:

Don't drop dollars. see #19426