Make WordPress Core

Opened 12 years ago

Closed 11 years ago

Last modified 11 years ago

#19445 closed defect (bug) (fixed)

Duplicated error code when user is a spammer

Reported by: sirzooro's profile sirzooro Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.0
Component: Multisite Keywords: has-patch commit
Focuses: Cc:

Description

"Your account has been marked as a spammer" message reuses the "invalid_username" error code. Attached path makes it unique. Without it is is impossible to distinguish these two error messages in plugin (e.g. to replace message with generic "invalid user or pass").

Attachments (3)

user.php.diff (564 bytes) - added by sirzooro 12 years ago.
user.php.2.diff (588 bytes) - added by sirzooro 12 years ago.
path with patches relative to root
19445.diff (661 bytes) - added by SergeyBiryukov 11 years ago.

Download all attachments as: .zip

Change History (8)

@sirzooro
12 years ago

#1 @ocean90
12 years ago

Please make your patches relativ to root. Core has more then one user.php. Makes it easier to apply the patch.

@sirzooro
12 years ago

path with patches relative to root

#2 @SergeyBiryukov
11 years ago

  • Milestone changed from Awaiting Review to 3.6

Makes sense to me. Refreshed.

#3 @SergeyBiryukov
11 years ago

  • Keywords commit added

#4 @SergeyBiryukov
11 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 23579:

Use distinct error code in wp_authenticate_username_password() when user is a spammer. props sirzooro. fixes #19445.

#5 @SergeyBiryukov
11 years ago

  • Component changed from Users to Multisite
  • Version changed from 3.2.1 to 3.0
Note: See TracTickets for help on using tickets.