WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#19470 closed defect (bug) (fixed)

Poor UX after redirecting to user ID anchor on Users screen

Reported by: johnbillion Owned by: nacin
Milestone: 3.4 Priority: normal
Severity: minor Version: 3.0
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

After adding a new user from the Users screen you're redirected to an anchor on the Users page (wp-admin/users.php?usersearch=newuser&update=add#user-2). This doesn't work well with the admin bar toolbar in place because it mostly covers up the point where the anchor is. This is more prominent now the toolbar is persistent in the admin area in 3.3.

Off the top of my head I can't think of any other screen which redirects to an anchor. Maybe we should just remove the anchor in the redirect? The redirect includes the usersearch parameter which should be enough in most cases anyway.

Attachments (4)

usersearch.png (15.9 KB) - added by johnbillion 2 years ago.
19470.patch (658 bytes) - added by SergeyBiryukov 2 years ago.
19470.2.patch (1.4 KB) - added by merty 2 years ago.
Here is the patch for my suggestion.
19470.3.patch (9.5 KB) - added by SergeyBiryukov 2 years ago.
An attempt to add the link to all the "Add User" screens (unfinished)

Download all attachments as: .zip

Change History (16)

johnbillion2 years ago

SergeyBiryukov2 years ago

comment:1 SergeyBiryukov2 years ago

  • Keywords has-patch added

comment:2 SergeyBiryukov2 years ago

  • Milestone changed from Awaiting Review to 3.4

comment:3 follow-up: merty2 years ago

  • Cc merty92@… added

What about adding an "Edit Profile" link to the end of the success message displayed after adding the new user succeeds, in order to make the life easier for those who want to edit the newly-added-user's profile immediately after?

merty2 years ago

Here is the patch for my suggestion.

comment:4 follow-up: merty2 years ago

  • Keywords ux-feedback added

comment:5 in reply to: ↑ 4 ; follow-up: jane2 years ago

  • Keywords ux-feedback removed

Replying to merty:
Would probably say "Edit User" rather than Edit Profile.

comment:6 in reply to: ↑ 5 merty2 years ago

Replying to jane: Me too, I used "Edit User" instead of "Edit Profile" in the patch. I wrote my initial post during a lecture so... (Yes, I was that bored) :)

Last edited 2 years ago by merty (previous) (diff)

SergeyBiryukov2 years ago

An attempt to add the link to all the "Add User" screens (unfinished)

comment:7 in reply to: ↑ 3 ; follow-up: SergeyBiryukov2 years ago

Replying to merty:

What about adding an "Edit Profile" link to the end of the success message

I guess we'd want to do that consistently for all the "Add User" screens, including several screens in Multisite. The patch turned out bigger than I initially thought. 19470.3.patch (unfinished) illustrates the idea.

Perhaps we should just fix the issue outlined in the description for now, and move the link addition to a new ticket.

comment:8 in reply to: ↑ 7 merty2 years ago

Replying to SergeyBiryukov:

Replying to merty:

What about adding an "Edit Profile" link to the end of the success message

I guess we'd want to do that consistently for all the "Add User" screens, including several screens in Multisite. The patch turned out bigger than I initially thought. 19470.3.patch (unfinished) illustrates the idea.

Perhaps we should just fix the issue outlined in the description for now, and move the link addition to a new ticket.

Yes, all of them should have the "Edit User" link. My patch was to give a general idea about my proposal but the real patch is way bigger than it as you mentioned so I agree that it deserves its own ticket for further discussions.

comment:9 nacin2 years ago

In [20630]:

Clean up messages on edit.php. see #19470.

comment:10 nacin2 years ago

A lot of the code proposed in this ticket is designed to clean up how we handle multisite redirects, which when dealing with users, is a bit of a mess. (I think I just re-defined the phrase "a bit" to mean "a lot".)

Let's just remove usersearch plus the anchor as proposed, and then provide a simple "Edit user" link.

comment:11 nacin2 years ago

And obviously the rest can happen in a future release.

comment:12 nacin2 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [20631]:

After adding a user, take them back to users.php with an 'Edit user' link in the message.

This removes the (possibly ineffective) search from the redirect, as well as the URL hash that will get covered up by the toolbar.

fixes #19470. props merty and SergeyBiryukov for initial patches.

Note: See TracTickets for help on using tickets.