WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#19475 closed defect (bug) (fixed)

New admin bar WP logo is strangely large, + icon missing hover state

Reported by: johnjamesjacoby Owned by: nacin
Milestone: 3.3 Priority: normal
Severity: normal Version: 3.3
Component: Toolbar Keywords: has-patch
Focuses: Cc:

Description

See #19404 and r19516.

The new, bigger WP logo makes the other icons look too small. If we're going big on the WP icon, all the icons should go big too (similar to the main OS X menu bar, Apple logo VS the tray icons.)

The "Add" menu icon is missing a hover state.

Attachments (3)

admin-bar-sprite.png (3.9 KB) - added by johnjamesjacoby 2 years ago.
Updated sprite with hover state for add menu
19475.diff (766 bytes) - added by johnjamesjacoby 2 years ago.
19475.2.diff (1.2 KB) - added by nacin 2 years ago.

Download all attachments as: .zip

Change History (19)

johnjamesjacoby2 years ago

Updated sprite with hover state for add menu

johnjamesjacoby2 years ago

comment:1 SergeyBiryukov2 years ago

  • Keywords has-patch added

comment:2 SergeyBiryukov2 years ago

  • Version set to 3.3

comment:3 follow-up: ocean902 years ago

  • Keywords ui-feedback added

The "Add" menu icon is missing a hover state.

At the moment only the WP icon has a hover state, search, update and add not.

comment:4 in reply to: ↑ 3 johnjamesjacoby2 years ago

Replying to ocean90:

The "Add" menu icon is missing a hover state.

At the moment only the WP icon has a hover state, search, update and add not.

That's the problem this patch fixes. On hover, the Add menu drops down. When down, the background color changes from dark gray to white. When white, the light gray plus graphic doesn't currently have a dark equivalent. This is obvious when looking at the current iteration of the admin bar.

comment:5 follow-up: jane2 years ago

When you have 2 separate issues like this, please put them on separate tickets for easier tracking.

Re the big icon: This was discussed in IRC, and was a Matt request. Think of the Apple icon compared to the file menu labels. Being bigger than the others was intentional. Wontfix.

Re hover state for Add New, I agree it would make the most sense for the + sign to change color along with the font for New. Should fix.

Grr. See how putting two issues on one ticket messes things up? :)

comment:6 jane2 years ago

  • Keywords ui-feedback removed

comment:7 koopersmith2 years ago

The patch doesn't apply cleanly, but when applied manually, it works.

comment:8 nacin2 years ago

The W logo could probably use a fresh coat of paint by chexee or emireoflight. It looks like the aliasing is off, a bit pixelated, rough around the edges.

Looking into the patch for the + icon.

nacin2 years ago

comment:9 follow-up: nacin2 years ago

  • Milestone changed from Awaiting Review to 3.3

Patch refreshed. Any reason why we need to re-specify background-image and -position? Is it there for reset purposes?

comment:10 in reply to: ↑ 9 johnjamesjacoby2 years ago

Replying to nacin:

Patch refreshed. Any reason why we need to re-specify background-image and -position? Is it there for reset purposes?

Was in my patch as it's how the logo worked; your revised patch fixes that. Can't imagine it's needed?

comment:11 in reply to: ↑ 5 ; follow-up: johnjamesjacoby2 years ago

Replying to jane:

Grr. See how putting two issues on one ticket messes things up? :)

If the WP logo changeset had its own ticket to reference, this wouldn't be so messed. :)

comment:12 in reply to: ↑ 11 ; follow-up: jane2 years ago

Replying to johnjamesjacoby:

If the WP logo changeset had its own ticket to reference, this wouldn't be so messed. :)

That's not true. You could have made two new tickets instead of one. I know you are just yanking my chain a little because we're friends, but new contributors reading this won't realize that and may actually believe that's a valid reason for putting two issues on one ticket.

comment:13 in reply to: ↑ 12 nacin2 years ago

Replying to jane:

Replying to johnjamesjacoby:

If the WP logo changeset had its own ticket to reference, this wouldn't be so messed. :)

That's not true. You could have made two new tickets instead of one. I know you are just yanking my chain a little because we're friends, but new contributors reading this won't realize that and may actually believe that's a valid reason for putting two issues on one ticket.

True. In fairness, jjj has a separate and valid point. All commits should have a corresponding ticket. He should know, considering I ribbed him on being guilty of this over on bbPress. :-)

comment:14 koopersmith2 years ago

Tested attachment:19475.2.diff. It works just as well, and the CSS is cleaner. I like.

comment:15 azaozz2 years ago

Yes, attachment:19475.2.diff looking good here too, tested all the way to IE7 rtl.

comment:16 nacin2 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [19578]:

Hover state for the Add New admin bar icon. props johnjamesjacoby. fixes #19475.

Note: See TracTickets for help on using tickets.