Make WordPress Core

Opened 13 years ago

Closed 12 years ago

#19476 closed enhancement (wontfix)

Expanded admin-bar Search causes my-account to move

Reported by: johnjamesjacoby's profile johnjamesjacoby Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.3
Component: Toolbar Keywords: has-patch
Focuses: Cc:

Description

Putting the search in the upper right corner causes the "My Account" menu to move when it is expanded. If a plugin positions new menus in the right-side area, they also end up moving. This ends up being a strange user experience, and actually looks like a bug, even if it's intentionally in the upper right hand corner.

Attached patch changes the priority of wp_admin_bar_search_menu to 200, forcing it to almost-always be the outermost item in that group, making it plugin friendly too.

Attachments (2)

19476.diff (762 bytes) - added by johnjamesjacoby 13 years ago.
Screen Shot 2011-12-09 at 3.34.07 AM.png (25.8 KB) - added by johnjamesjacoby 13 years ago.

Download all attachments as: .zip

Change History (8)

#1 @johnjamesjacoby
13 years ago

BuddyPress is using the 3.3 My Account menu to attach user profile related links, and also puts its notifications menu to the left of it. Expanding the Search box open naturally moves both the core My Account menu, and the BuddyPress Notifications menu.

#2 @SergeyBiryukov
13 years ago

  • Keywords has-patch added
  • Version set to 3.3

#3 follow-up: @jane
13 years ago

  • Type changed from defect (bug) to enhancement

This won't be changed for 3.3. Changing to enhancement because it does what we expected it to do.

#4 in reply to: ↑ 3 @johnjamesjacoby
13 years ago

Replying to jane:

This won't be changed for 3.3. Changing to enhancement because it does what we expected it to do.

It's changed in every 3.3 beta and RC. Meeting expectations doesn't make it the best possible result. We're compromising usability for aesthetics with this change. Attaching a screen shot of it in action.

#5 @jane
13 years ago

Yep, just like it is on .com, where it's been like that for a long while. We switched to the .com placement after trying just about every other, and specifically at Matt's request.

#6 @johnjamesjacoby
12 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Closing as wontfix

Note: See TracTickets for help on using tickets.