WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#19477 closed enhancement (fixed)

RTL for the About page

Reported by: rasheed Owned by: ryan
Milestone: 3.3 Priority: normal
Severity: normal Version: 3.3
Component: RTL Keywords: has-patch commit
Focuses: Cc:

Description

Some screenshots needs to be moved to left at the About page (wp-admin/about.php).

Please check the attachment.

.about-wrap .feature-section.images-stagger-right .feature-images {
    right: 0; (should be left)
}

Attachments (11)

Untitled-1.gif (67.6 KB) - added by rasheed 4 years ago.
19477.diff (557 bytes) - added by helenyhou 4 years ago.
Untitled-1.2.gif (4.3 KB) - added by rasheed 4 years ago.
19477.2.diff (974 bytes) - added by helenyhou 4 years ago.
19477.3.diff (1.4 KB) - added by helenyhou 4 years ago.
19477.4.diff (741 bytes) - added by nacin 4 years ago.
19477.5.diff (1.5 KB) - added by SergeyBiryukov 4 years ago.
19477.LTR.png (228.6 KB) - added by SergeyBiryukov 4 years ago.
Current LTR screen
19477.RTL.png (230.3 KB) - added by SergeyBiryukov 4 years ago.
Current RTL screen
19477.2.png (230.6 KB) - added by SergeyBiryukov 4 years ago.
With 19477.2.diff
19477.5.png (230.9 KB) - added by SergeyBiryukov 4 years ago.
With 19477.5.diff

Download all attachments as: .zip

Change History (24)

@rasheed4 years ago

@helenyhou4 years ago

comment:1 follow-up: @helenyhou4 years ago

19477.diff will move those images to the left. Maybe should be noted that the .three-col features at the bottom are not switched around, either.

comment:2 in reply to: ↑ 1 @rasheed4 years ago

Replying to helenyhou:

19477.diff will move those images to the left. Maybe should be noted that the .three-col features at the bottom are not switched around, either.

Yes, the whole page should be RTLized.

@rasheed4 years ago

comment:3 @rasheed4 years ago

Version 0, edited 4 years ago by rasheed (next)

comment:4 @nacin4 years ago

  • Milestone changed from Awaiting Review to 3.3
  • Summary changed from Screenshots position at the About page to RTL for the About page

@helenyhou4 years ago

@helenyhou4 years ago

comment:5 @helenyhou4 years ago

19477.3.diff should take care of everything mentioned above. I had put text-align:right for all of the .three-col h4's at first, hence 19477.2.diff, but it's just added to the inline style in 19477.3.diff.

comment:6 @helenyhou4 years ago

  • Keywords has-patch added

comment:7 @jane4 years ago

Heading alignment, cool.

For the record, the screenshots just need to be next to the appropriate text, there's no need for them to be specifically left or right of the text. As anyone who was involved in the original ticket will remember, we bounced them back and forth a bunch of times, so it really doesn't matter, as long as they are in the correct sections of the screen.

comment:8 follow-up: @nacin4 years ago

<h4 style="direction:ltr;text-align:right"> doesn't do too well on LTR. :-)

@nacin4 years ago

comment:9 in reply to: ↑ 8 @helenyhou4 years ago

Replying to nacin:

<h4 style="direction:ltr;text-align:right"> doesn't do too well on LTR. :-)

Hah, oops. 19477.2.diff then? I'm a master artisan of great foresight.

@SergeyBiryukov4 years ago

@SergeyBiryukov4 years ago

Current LTR screen

@SergeyBiryukov4 years ago

Current RTL screen

@SergeyBiryukov4 years ago

With 19477.2.diff

@SergeyBiryukov4 years ago

With 19477.5.diff

comment:10 @SergeyBiryukov4 years ago

19477.5.diff (based on 19477.2.diff) offers some more adjustments for better compliance with current LTR styles. Fixes .angled-left/.angled-right order and .three-col img padding as well. Added screenshots.

comment:12 @nacin4 years ago

  • Keywords commit added

Looks good. Nice work, helenyhou and SergeyBiryukov.

comment:13 @ryan4 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [19575]:

RTL fixes for the about page. Props helenyhou, SergeyBiryukov. fixes #19477

Note: See TracTickets for help on using tickets.