WordPress.org
Get WordPress

Make WordPress Core

Opened 13 years ago

Closed 13 years ago

#19498 closed defect (bug) (fixed)

Press this add image from URL bugs

Reported by: greuben's profile greuben Owned by: nacin's profile nacin
Milestone: 3.3.2 Priority: normal
Severity: major Version: 3.3
Component: Press This Keywords: has-patch
Focuses: Cc:

Description

Two bugs

  1. Add image from url form works only once. Click "Add From URL", insert an image and try it again, the form is not displayed.
  1. Click "Add From URL" then click cancel, then form is appended to the body and is visible.

Attachments (3)

pressthis.diff​ (776 bytes) - added by greuben 13 years ago.
19498.diff​ (921 bytes) - added by greuben 13 years ago.
19498-2.patch​ (1.2 KB) - added by azaozz 13 years ago.

Download all attachments as: .zip

Change History (13)

@greuben
13 years ago

#1 @ocean90
13 years ago

  • Milestone changed from Awaiting Review to 3.3

It's an regression.

Patch does display the form, but it's still prefilled.

@greuben
13 years ago

#2 @nacin
13 years ago

  • Priority changed from normal to highest omg bbq
  • Severity changed from major to critical

@azaozz
13 years ago

#3 follow-up: @azaozz
13 years ago

19498-2.patch reverts back to cloning #photo-add-url-div.

#4 @nacin
13 years ago

  • Milestone changed from 3.3 to 3.3.1
  • Priority changed from highest omg bbq to normal
  • Severity changed from critical to major

#5 in reply to: ↑ 3 @nacin
13 years ago

Replying to azaozz:

19498-2.patch reverts back to cloning #photo-add-url-div.

Anyone know the history as to why/where this changed away from this?

#6 @azaozz
13 years ago

As far as I remember there was a bug related to duplicate HTML IDs in Press This. When cloning a DOM node or sub-branch, all cloned nodes end up duplicating the IDs from the originals. Easiest solutions to that are either not to use HTML IDs in the sub-branch or to move it instead of cloning (however neither would be a straight replacement in this case).

#7 @nacin
13 years ago

Tracked this down to [19424/trunk/wp-admin/press-this.php]. Thanks for the explanation.

#8 @nacin
13 years ago

In [19664]:

Revert a piece of [19424], go back to cloning a div for adding images in Press This. props azaozz, see #19498 for trunk.

#9 @nacin
13 years ago

  • Milestone changed from 3.3.1 to 3.3.2

#10 @nacin
13 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [20542]:

Revert a piece of [19424], go back to cloning a div for adding images in Press This. props azaozz, fixes #19498 for 3.3.

Note: See TracTickets for help on using tickets.