WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#19538 closed defect (bug) (fixed)

Multi-site Upload Limit Stuck at 50MB

Reported by: wspnut Owned by: ryan
Milestone: 3.3.1 Priority: normal
Severity: critical Version: 3.3
Component: Upload Keywords: has-patch commit
Focuses: Cc:

Description

Hey all,

This has been confirmed by multiple users. After upgrading to WP3.3, all sites on the multi-site, except for the initial site / (or /blog/) are stuck at a 50MB upload limit, if upload limiting is enabled.

This took effect as soon as the upgrade to WP3.3 was complete. Changing the site's individual upload limit, as well as changing the network-wide limit, took no effect. This occurs with all plugins disabled, as well.

This is a critical bug for us, as our sites cannot upload any media with the cap so low.

Attachments (3)

19538.diff (518 bytes) - added by wpmuguru 2 years ago.
19538.2.diff (666 bytes) - added by wpmuguru 2 years ago.
19538.hotfix.diff (870 bytes) - added by nacin 2 years ago.

Download all attachments as: .zip

Change History (24)

comment:1 wpmuguru2 years ago

  • Keywords reporter-feedback added

What value are you filling in for the limit?

comment:2 wspnut2 years ago

Network setting was set to "1024" (no quotes)

Per-site setting I tried with both "100" and a blank value

comment:3 wpmuguru2 years ago

  • Keywords has-patch added; reporter-feedback removed

I entered those values in my dev install and the dashboard of the subsite says 100MB of space.

If I leave the option empty on the individual site I do get the 50MB.

wpmuguru2 years ago

comment:5 wspnut2 years ago

Patch fixed it. Thanks wpmugru.

wpmuguru2 years ago

comment:6 wpmuguru2 years ago

19538.2.diff also retains the support for the 0 upload limit.

comment:7 anointed2 years ago

Patch solved the problem for me. Thank you wpmugru!

comment:8 ocean902 years ago

  • Milestone changed from Awaiting Review to 3.3.1

Related: #18119/r19314

nacin2 years ago

comment:9 nacin2 years ago

19538.hotfix.diff is a patch for the Hotfix plugin. Can someone test?

comment:10 nacin2 years ago

We're doing === '' and === false to avoid catching '0' / 0, I imagine. In that case, we can just move to is_numeric().

comment:11 nacin2 years ago

In [19639]:

Better checking for values for multisite upload limits. see #19538 for trunk.

comment:12 nacin2 years ago

  • Keywords commit added

Marking as commit for the 3.3 branch, after additional review.

comment:13 wpmuguru2 years ago

That looks fine to me.

comment:14 nacin2 years ago

[19639] means that a site option of 0 will enforce the 0. While it makes it consistent, I don't know if that's a good change for a point release.

comment:15 nacin2 years ago

This broke some unit tests. We should also add new ones to account for any changes.

comment:16 ryan2 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [19645]:

Better checking for values for multisite upload limits. fixes #19538 for 3.3

comment:17 nacin2 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened
Re-opening for comment:14 and comment:15. I would like to change back to empty()
is_numeric() for the second conditional for 3.3.1 only, as that attempt at standardization can introduce a change in behavior.
Version 0, edited 2 years ago by nacin (next)

comment:18 nacin2 years ago

In [19652]:

Revert half of [19639]. If the blog_upload_space site_option is '0', restore 50 as a default. see #19538.

comment:19 nacin2 years ago

The piece reverted in [19652] looked good. However, it introduces a change in a point release that could disable uploads for an entire network. Let's not include that in the 3.3 branch.

comment:20 nacin2 years ago

In [19654]:

Revert half of [19639]. If the blog_upload_space site_option is '0', restore 50 as a default. see #19538 for 3.3.

comment:21 nacin2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Any further fixes should be a new ticket for 3.4.

Note: See TracTickets for help on using tickets.