Make WordPress Core

Opened 12 years ago

Closed 10 years ago

Last modified 10 years ago

#19555 closed enhancement (fixed)

Deprecate url_is_accessable_via_ssl()

Reported by: nacin's profile nacin Owned by: johnbillion's profile johnbillion
Milestone: 4.0 Priority: normal
Severity: normal Version:
Component: HTTP API Keywords: has-patch
Focuses: Cc:


We can convert it to use wp_remote_get() when we do, or just stub it.

Attachments (2)

19555.patch (2.3 KB) - added by jgadbois 12 years ago.
19555-unit-test.patch (1.9 KB) - added by kurtpayne 12 years ago.
Unit test

Download all attachments as: .zip

Change History (11)

12 years ago

#1 @jgadbois
12 years ago

  • Keywords has-patch added

#2 @jgadbois
12 years ago

  • Cc jgadbois@… added

12 years ago

Unit test

#3 @kurtpayne
12 years ago

  • Cc kpayne@… added

I would like to see the documentation in 19555.patch updated to reflect @since 3.4.0 (or just 3.4 ... not sure about the strictness of the convention) and have "Requires cURL" removed since this is no longer true. Otherwise the patch works. Unit test patch submitted, too.

#4 @nacin
12 years ago

  • Milestone changed from 3.4 to Future Release

Looks good.

#5 @nacin
10 years ago

  • Component changed from General to HTTP
  • Type changed from defect (bug) to enhancement


#6 @dd32
10 years ago

Looks good to me, only nitpick is that it shouldn't be filtering https_ssl_verify & needs updating to match our whitespace format.

#7 @johnbillion
10 years ago

  • Milestone changed from Future Release to 4.0

#8 @johnbillion
10 years ago

  • Owner set to johnbillion
  • Resolution set to fixed
  • Status changed from new to closed

In 28709:

Deprecate url_is_accessable_via_ssl(). Fixes #19555. Props jgadbois.

#9 @johnbillion
10 years ago

In 28710:

Correct the deprecated function parameter in url_is_accessable_via_ssl(). See #19555.

Note: See TracTickets for help on using tickets.