WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 10 months ago

Last modified 10 months ago

#19555 closed enhancement (fixed)

Deprecate url_is_accessable_via_ssl()

Reported by: nacin Owned by: johnbillion
Milestone: 4.0 Priority: normal
Severity: normal Version:
Component: HTTP API Keywords: has-patch
Focuses: Cc:

Description

We can convert it to use wp_remote_get() when we do, or just stub it.

Attachments (2)

19555.patch (2.3 KB) - added by jgadbois 3 years ago.
19555-unit-test.patch (1.9 KB) - added by kurtpayne 3 years ago.
Unit test

Download all attachments as: .zip

Change History (11)

@jgadbois3 years ago

comment:1 @jgadbois3 years ago

  • Keywords has-patch added

comment:2 @jgadbois3 years ago

  • Cc jgadbois@… added

@kurtpayne3 years ago

Unit test

comment:3 @kurtpayne3 years ago

  • Cc kpayne@… added

I would like to see the documentation in 19555.patch updated to reflect @since 3.4.0 (or just 3.4 ... not sure about the strictness of the convention) and have "Requires cURL" removed since this is no longer true. Otherwise the patch works. Unit test patch submitted, too.

comment:4 @nacin3 years ago

  • Milestone changed from 3.4 to Future Release

Looks good.

comment:5 @nacin14 months ago

  • Component changed from General to HTTP
  • Type changed from defect (bug) to enhancement

dd32?

comment:6 @dd3214 months ago

Looks good to me, only nitpick is that it shouldn't be filtering https_ssl_verify & needs updating to match our whitespace format.

comment:7 @johnbillion10 months ago

  • Milestone changed from Future Release to 4.0

comment:8 @johnbillion10 months ago

  • Owner set to johnbillion
  • Resolution set to fixed
  • Status changed from new to closed

In 28709:

Deprecate url_is_accessable_via_ssl(). Fixes #19555. Props jgadbois.

comment:9 @johnbillion10 months ago

In 28710:

Correct the deprecated function parameter in url_is_accessable_via_ssl(). See #19555.

Note: See TracTickets for help on using tickets.