WordPress.org
Get WordPress

Make WordPress Core

Opened 15 years ago

Closed 12 years ago

Last modified 12 years ago

#19555 closed enhancement (fixed)

Deprecate url_is_accessable_via_ssl()

Reported by: nacin Owned by: johnbillion
Priority: normal Milestone: 4.0
Component: HTTP API Version:
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

We can convert it to use wp_remote_get() when we do, or just stub it.

Attachments (2)

19555.patch​ (2.3 KB ) - added by jgadbois 15 years ago.
19555-unit-test.patch​ (1.9 KB ) - added by kurtpayne 15 years ago.
Unit test

Download all attachments as: .zip

Change History (11)

@jgadbois
15 years ago

#1 @jgadbois
15 years ago

  • Keywords has-patch added

#2 @jgadbois
15 years ago

  • Cc jgadbois@… added

@kurtpayne
15 years ago

Unit test

#3 @kurtpayne
15 years ago

  • Cc kpayne@… added

I would like to see the documentation in 19555.patch​ updated to reflect @since 3.4.0 (or just 3.4 ... not sure about the strictness of the convention) and have "Requires cURL" removed since this is no longer true. Otherwise the patch works. Unit test patch submitted, too.

#4 @nacin
14 years ago

  • Milestone 3.4 → Future Release

Looks good.

#5 @nacin
13 years ago

  • Component General → HTTP
  • Type defect (bug) → enhancement

dd32?

#6 @dd32
13 years ago

Looks good to me, only nitpick is that it shouldn't be filtering https_ssl_verify & needs updating to match our whitespace format.

#7 @johnbillion
12 years ago

  • Milestone Future Release → 4.0

#8 @johnbillion
12 years ago

  • Owner set to johnbillion
  • Resolution → fixed
  • Status new → closed

In 28709:

Deprecate url_is_accessable_via_ssl(). Fixes #19555. Props jgadbois.

#9 @johnbillion
12 years ago

In 28710:

Correct the deprecated function parameter in url_is_accessable_via_ssl(). See #19555.

Note: See TracTickets for help on using tickets.