WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#19563 closed defect (bug) (fixed)

feed generator does not correctly detect if we run on https

Reported by: duritong Owned by: dd32
Milestone: 3.4 Priority: normal
Severity: normal Version:
Component: Feeds Keywords: has-patch
Focuses: Cc:

Description

wp-includes/feed.php does not correctly detect, whether the feed is accessed via https or not, so it will always generate an http-only link.

This is because it looks for

$_SERVER['https']

instead of

$_SERVER['HTTPS']

Other wordpress scripts are already looking for:

$_SERVER['HTTPS']

So fix is quite simple and patch is attached and uploaded here: https://gist.github.com/1481164

Attachments (1)

fix.patch (553 bytes) - added by duritong 2 years ago.
fix for https on feed issue

Download all attachments as: .zip

Change History (5)

duritong2 years ago

fix for https on feed issue

comment:1 kawauso2 years ago

  • Keywords has-patch added; rss https removed

comment:2 johnbillion2 years ago

It should actually be using is_ssl().

comment:3 dd322 years ago

  • Milestone changed from Awaiting Review to 3.4
  • Owner set to dd32
  • Status changed from new to assigned

Yep, we should be using is_ssl() here.

comment:4 dd322 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In [19598]:

Use is_ssl() in self_link(). Fixes #19563

Note: See TracTickets for help on using tickets.