Make get_search_form() more filterable/extensible
|Reported by:||chipbennett||Owned by:|
|Component:||Themes||Keywords:||has-patch needs-testing needs-refresh|
I notice that a lot of the time when Themes include custom search form markup via searchform.php, they are making very minor changes to the default markup. (A common on is adding onfocus/onblur attributes to the input.) Unfortunately, I've also noticed that custom search form markup tends to be... forgotten, and ends up becoming more insecure over time.
So, in the interest of encouraging/facilitating use of the core markup, I propose making get_search_form() more extensible, similar to the extensibility of comment_form().
This patch replaces $echo = true with $args = array() as the parameter passed to get_search_form(), while retaining backward compatibility with $echo = true. Also, a (self-explanatory) search_form_defaults filter is added.
Also addresses #16538
Does not address #16541, which is potentially related.
Probably conflicts with #14851
Also related: #19321