WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #19592, comment 17


Ignore:
Timestamp:
02/18/12 22:09:07 (2 years ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #19592, comment 17

    initial v1  
    1212}}} 
    1313 
    14 Thinking we should keep it UTF-8 as that affects the output too. Perhaps it's worth it having some basic charset detection or running `mb_detect_encoding()`. Alternatively can try to detect invalid chars in the output and not commit that minified file, showing a warning in the commit message. 
     14Thinking we should keep it UTF-8 as that affects the output too. Perhaps it's worth it having some basic charset detection or running `mb_detect_encoding()` and then `iconv`. Alternatively can try to detect invalid chars in the output and not commit that minified file, showing a warning in the commit message. 
    1515 
    1616In that particular case the file comes pre-minified in the TinyMCE distribution package and we will be skipping processing the pre-minified files there as discussed with @nacin in IRC.