Changes between Version 1 and Version 2 of Ticket #19592, comment 17
- Timestamp:
- 02/18/2012 10:17:55 PM (14 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #19592, comment 17
v1 v2 12 12 }}} 13 13 14 Thinking we should keep it UTF-8 as that affects the output too. Perhaps it's worth it having some basic charset detection or running `mb_detect_encoding()` and then `iconv`. Alternatively can try to detect invalid chars in the output and not commit that minified file, showing a warning in the commit message.14 Thinking we should keep it UTF-8 as that affects the output too. Perhaps it's worth it having some basic charset detection or running `mb_detect_encoding()` and then `iconv`. Alternatively can try to detect invalid chars in the output `iconv("UTF-8","UTF-8", $string)` and not commit that minified file, showing a warning in the commit message. 15 15 16 16 In that particular case the file comes pre-minified in the TinyMCE distribution package and we will be skipping processing the pre-minified files there as discussed with @nacin in IRC.