Incorrect plugin ratings on decimal comma locales

[SergeyBiryukov]

On ​some PHP locales, comma is used as a decimal separator.

This creates visual problems with plugin ratings and tag cloud on Install Plugins screen (see the screenshot).

Browser fails to handle font-size attributes with commas properly, as CSS specification only supports decimal point as a separator:
​http://www.w3.org/TR/CSS21/syndata.html#length-units

To reproduce, add this to wp-config.php:

setlocale(LC_ALL, 'fr_FR');

unserialize() in plugins_api() would then return values with commas, even if WP.org API returns them with points: ​http://core.trac.wordpress.org/browser/tags/3.3/wp-admin/includes/plugin-install.php#L48

Related: #18460

[nacin]

Perhaps the API call could return a string instead?

[SergeyBiryukov]

Replying to nacin:

Perhaps the API call could return a string instead?

I guess that would fix the ratings, but not the tag cloud (see the second screenshot).

[nacin]

That sounds like a problem with the tag cloud code, not here.

[SergeyBiryukov]

Right. #19624

[nacin]

In the future, we should probably have a helper for this.

[nacin]

$theme->rating (which has moved to the customizer, so this patch no longer applies cleanly) is a number 1-100. It can be a float (the API simply takes the 1-5 rating and multiplies it by 20 to give a percentage), but the customizer intval()'s it. So we're good there.

[nacin]

In [20675]:

Replace commas with periods when converting ratings float values to strings, to avoid issues with localized decimal points.

In these cases, we want a period because it is going to be used by CSS.

props SergeyBiryukov.
fixes #19593.