WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

#19594 closed defect (bug) (fixed)

Admin bar search button should indicate it's clickable

Reported by: jaquers Owned by: nacin
Milestone: 3.4 Priority: normal
Severity: normal Version:
Component: Toolbar Keywords: has-patch commit
Focuses: Cc:

Description

When you hover over the search button in the admin bar, the cursor should indicate that it's clickable.

Attachments (3)

admin-bar.dev.css (12.7 KB) - added by jaquers 4 years ago.
Added cursor: pointer to a couple rules.
admin-bar.dev.patch (497 bytes) - added by jaquers 4 years ago.
admin-bar.dev.css.patch (897 bytes) - added by jaquers 4 years ago.
Updated patch to address focus state cursor appearance.

Download all attachments as: .zip

Change History (12)

@jaquers4 years ago

Added cursor: pointer to a couple rules.

@jaquers4 years ago

comment:1 @jaquers4 years ago

Sorry for my noobness about filing and creating patches.. Hopefully you can overlook for the small change that this is :)

comment:2 @SergeyBiryukov4 years ago

According to ticket:18197:146, current behaviour is proper.

comment:3 @SergeyBiryukov4 years ago

  • Keywords ui-feedback added

comment:4 @nacin4 years ago

  • Component changed from General to Toolbar
  • Milestone changed from Awaiting Review to 3.4

Yeah, but now that it's an icon, rather than a short text box that grows, it should get a hand.

comment:5 @SergeyBiryukov4 years ago

With the current patch, the pointer cursor is displayed even when the text box is expanded.

@jaquers4 years ago

Updated patch to address focus state cursor appearance.

comment:6 @jaquers4 years ago

  • Keywords needs-testing added

comment:7 @SergeyBiryukov4 years ago

admin-bar.dev.css.patch looks good. Tested in Firefox 9, Chrome 16, Opera 11.60, IE 8.

comment:8 @ocean904 years ago

  • Keywords commit added; ui-feedback needs-testing removed

Works.

comment:9 @nacin3 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [19703]:

Show cursor for the search icon. props jaquers. fixes #19594.

Note: See TracTickets for help on using tickets.