WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#19610 closed defect (bug) (fixed)

Toolbar shows up after clicking a link in theme preview

Reported by: SergeyBiryukov Owned by: nacin
Milestone: 3.4 Priority: normal
Severity: normal Version:
Component: Themes Keywords: has-patch commit
Focuses: Cc:

Description

  1. Click "Preview" link for any theme (checked with Twenty Ten).
  2. Click any link in the iframe.
  3. Notice the Toolbar.

Related: #16659

Attachments (2)

19610.preview.png (20.6 KB) - added by SergeyBiryukov 2 years ago.
19610.patch (714 bytes) - added by linuxologos 2 years ago.

Download all attachments as: .zip

Change History (8)

SergeyBiryukov2 years ago

linuxologos2 years ago

comment:1 linuxologos2 years ago

  • Keywords has-patch added

19610.patch adds the preview_iframe query variable to the preview theme links (just like the fix for #16659).

comment:2 SergeyBiryukov2 years ago

  • Milestone changed from Awaiting Review to 3.4

comment:3 SergeyBiryukov2 years ago

  • Keywords commit added

comment:4 nacin2 years ago

Surprised this wasn't noticed previously. Doesn't seem like a regression though.

comment:5 nacin2 years ago

Ah, okay. Only after you click.

comment:6 nacin2 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [19617]:

Hide the toolbar on all subsequent links in the theme preview. props linuxologos, fixes #19610.

Note: See TracTickets for help on using tickets.