Opened 13 years ago
Closed 13 years ago
#19616 closed enhancement (duplicate)
Color Picker consistency
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 3.2 |
Component: | UI | Keywords: | has-patch |
Focuses: | Cc: |
Description
The color pickers used on the custom background page and custom header pages appear and behave slightly differently.
On the Custom Background page, the picker uses a non-button/text trigger, and once a color is entered a 'clear' option is added.
On the Custom Header page, the picker uses a button trigger. No 'clear' option is offered.
Twenty Eleven's Theme Options includes another variation:
It is very similar to the Custom Header style, but with an added color swatch preview.
Attachments (6)
Change History (29)
#4
@
13 years ago
Here's the custom-background.php diff file. It was pretty straightforward overall. I didn't include the little swatch preview because of the preview at the top is so prominent. http://core.trac.wordpress.org/attachment/ticket/19616/custombg.diff
#5
@
13 years ago
A bit curious how to go about the color swatch option. I believe a lot of that part is utilizing some jquery + css, to restrict the size of the swatch and make it clickable with the color wheel. However, as I'm still new to the core editing, I am not sure which files the js/css should go into.
#11
@
13 years ago
- Keywords needs-refresh commit added
This needs a slight refresh for trunk, I imagine.
#12
follow-up:
↓ 13
@
13 years ago
- Keywords needs-refresh removed
The new patch (19616.diff) moves everything to the Twentyeleven style with the swatch. I like the swatch, it seems like the friendliest option. I also went with the button instead of the link and added the clear link when a color is selected. I even did that on the background page for two reasons:
- Consistency is nice, even if there are two color previews (swatch and big preview box at the top)
- If the background image is set to tile, you can't see the background color. I know that this means you can't see the background color on the site either (in theory), but since the color picker is still there having the swatch makes it more usable.
#13
in reply to:
↑ 12
;
follow-up:
↓ 14
@
13 years ago
Replying to aaroncampbell:
The new patch (19616.diff) moves everything to the Twentyeleven style with the swatch.
One issue I saw in testing: the swatch should trigger the same click event as the "Select a Color" button (broken in both Background and Header).
The rest tests out, works as expected.
#14
in reply to:
↑ 13
@
13 years ago
Replying to lancewillett:
One issue I saw in testing: the swatch should trigger the same click event as the "Select a Color" button (broken in both Background and Header).
Good catch. Fixed it in 19616.2.diff
#15
@
13 years ago
- Milestone changed from 3.4 to Future Release
17:13 koopersmith For the love of everything, punt.
+1