WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#19619 closed task (blessed) (fixed)

Simplify UI for searching in the plugin and theme installers

Reported by: nacin Owned by: nacin
Milestone: 3.4 Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords: has-patch needs-ui
Focuses: Cc:

Description (last modified by nacin)

Currently the theme and plugin installers provide not only a search box, but a dropdown for searching author, tag, and term. Term should really be keyword, but more to the point, we just shouldn't have this dropdown at all.

When using "term", the plugins info API will already do a weighted search that includes tags. And we already have a tag cloud that could be used to explicitly search by tags. Themes search isn't as clever (I don't think) but themes have a defined set of tags which are already available via the filter.

The last one, author, is particularly niche. We can support it in two ways: one, via a special search parameter, and two, by hijacking the "By Andrew Nacin" link to point to an in-dashboard author page for the user. (Not done here.)

Attached patch handles the plugin installer only. It introduces some new shortcuts for searching for a specific tag or author, via 'author:' and 'tag:'. It does not work translated yet, and should probably work with a space after the : as well.

This patch needs to be applied to 3.4, as the plugin info API will only return the author info we need for 3.4.

Attachments (5)

19619.diff (5.6 KB) - added by nacin 3 years ago.
19619.2.diff (10.9 KB) - added by nacin 3 years ago.
Includes themes.
19619.search-needs-type.diff (722 bytes) - added by georgestephanis 3 years ago.
19619.theme-search.png (157.2 KB) - added by SergeyBiryukov 3 years ago.
19619.search-needs-type.2.diff (1.4 KB) - added by SergeyBiryukov 3 years ago.

Download all attachments as: .zip

Change History (15)

@nacin3 years ago

comment:1 @nacin3 years ago

  • Description modified (diff)

comment:2 @scribu3 years ago

The last one, author, is particularly niche. We can support it in two ways: one, via a special search parameter, and two, by hijacking the "By Andrew Nacin" link to point to an in-dashboard author page for the user. (Not done here.)

So that page would presumably display a list of said author's plugins, which would open in the same lightbox. That might work, but I don't really see the need if author:X searches work.

@nacin3 years ago

Includes themes.

comment:3 @ryan3 years ago

Sounds good and works for me.

comment:4 @nacin3 years ago

  • Keywords needs-ui added; dev-feedback removed

Needs UI. Also, we can pull in things like the person's bio as well.

comment:5 @scribu3 years ago

  • Summary changed from Simplify UI for searching for the plugin and theme installers to Simplify UI for searching in the plugin and theme installers

comment:6 @nacin3 years ago

In [20333]:

Use 'Keyword' instead of 'Term' in the search type selector in the plugin and theme installers. see #19619.

comment:7 @nacin3 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [20592]:

Reduce clutter and repetive functionality from the initial landing page for installing plugins and themes by removing the tag/author/term dropdown.

The tag cloud (plugins) and feature filter (themes) is sufficient for tag functionality. All three "search by" fields are already weighted for a standard keyword search through the WP.org API.

fixes #19619 for 3.4.

comment:8 @georgestephanis3 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Lack of type being specified by abbreviated search form results in all results being returned ( see: http://cl.ly/3O412M090p0w2J2n3z21 -- look at the URL and its missing variable ). Adding it back in as a hidden field with latest patch for great justice.

~/wp-admin/plugin-install.php?tab=search&s=akismet&plugin-search-input=Search+Plugins

comment:9 @SergeyBiryukov3 years ago

Same for themes (see the screenshot).

comment:10 @nacin3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In [20639]:

Default to keyword searches for the plugin and theme installers in case no search type is posted back. fixes #19619.

props georgestephanis, SergeyBiryukov for initial patches.

Note: See TracTickets for help on using tickets.