Opened 13 years ago
Closed 13 years ago
#19644 closed defect (bug) (fixed)
Unwanted backslash in output
Reported by: | donpaolo | Owned by: | ryan |
---|---|---|---|
Milestone: | 3.3.1 | Priority: | normal |
Severity: | minor | Version: | 3.3 |
Component: | UI | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
After upgrading to 3.3 I got the windows notificating me the new features.
the "Media uploader updated" notification says in italian translation:
Ora l\'icona unificata "media" lancia un uploader per tutti i tipi di file, e la nuova interfaccia "drag and drop" rende il caricamento un gioco da ragazzi.
You see there is a backslash which shouldn't be there. I think it's not a translation error, but a bug in the treating of those strings.
Attachments (1)
Change History (7)
#2
@
13 years ago
- Keywords needs-patch added
- Milestone changed from Awaiting Review to 3.3.1
The problem is in json_encode( esc_js( ) )
:
$string = "Foo'bar \"Hello\""; var_dump( ( esc_js( $string ) ); // string(26) "Foo\'bar "Hello"" var_dump( json_encode( esc_js( $string ) ) ); // string(29) ""Foo\\'bar "Hello""" var_dump( json_encode( $string ); // string(19) ""Foo'bar \"Hello\""" var_dump( esc_js( json_encode( $string ) ) ); // string(38) ""Foo\'bar "Hello"""
#3
@
13 years ago
- Keywords has-patch dev-feedback added; needs-patch removed
19644.patch does remove the esc_js
calls.
Note: See
TracTickets for help on using
tickets.
The translation is:
Ora l'icona unificata \"media\" lancia un uploader per tutti i tipi di file, e la nuova interfaccia \"drag and drop\" rende il caricamento un gioco da ragazzi.