Use add_node() instead of add_menu() in core

[linuxologos]

'It's clear through ​class-wp-admin-bar.php and Nacin ​has stated this too:

The API previously emphasized add_menu(), but this can be confusing, so add_node() is now being promoted a bit more.

Another step towards this would be that the core used add_node() instead of add_menu() when building menu items in ​admin-bar.php.

Proposed patch replaces all references to the add_menu() method with the add_node() one. (Also some code structure modifications for wp_admin_bar_appearance_menu().)

[nacin]

Ryan, you game?

[johnbillion]

Needs a patch minus the unnecessary formatting changes.

[paulschreiber]

add_node() changes only; no formatting changes

[morganestes]

Adds a deprecated notice to add_menu() and directs use of add_node()

[akibjorklund]

Refreshed patch

[morganestes]

Refreshed and added docs to include remove_menu

[morganestes]

Add unit tests for refreshed patch.

[whyisjake]

Looks great Morgan, going to get this committed.

[whyisjake]

In 46642:

Toolbar: Use add_node() instead of add_menu() in core.

This patch replaces all references to the add_menu() method with the add_node() one. (Also some code structure modifications for wp_admin_bar_appearance_menu().)

Fixes: #19647
Props: linuxologos, paulschreiber, morganestes, akibjorklund, nacin, whyisjake.

[johnbillion]

I'm not sure that this deprecated notice provides much value. Most plugins that add an admin toolbar menu are using the add_menu() method, as was core until this changeset.

A search for >add_menu( in the plugin directory returns over 1,200 results: ​https://wpdirectory.net/search/01DS0ZDS11A6JZEF4VH3SNVZAF

I'd like to propose removing the deprecated notice for this method. It might have made sense eight years ago but it now seems like an unnecessary deprecation given its widespread usage.

[whyisjake]

@johnbillion, I removed the test and the deprecated warnings, thoughts?

[johnbillion]

Thanks Jake! I'm going to make an executive decision and go ahead with this as per my comment above.

[johnbillion]

In 46678:

Toolbar: Un-deprecate the WP_Admin_Bar::add_menu() method.

This is only a wrapper for the add_node() method, but it's in widespread use both in core until [46642] and in thousands of plugins and themes. Deprecating it would have made sense when #19647 was originally opened but that's no longer the case.

Props whyisjake

Fixes #19647

[afercia]

@johnbillion when you have a chance: both add_menu() and remove_menu() still have a @since notation mentioning the deprecation. Should those be removed as well?

* @since 5.4.0 Deprecated in favor of {@see WP_Admin_Bar::add_node()}.
* @since 5.4.0 Deprecated in favor of {@see WP_Admin_Bar::remove_node()}.

[afercia]

In 47108:

Toolbar: Remove leftover @since notations after [46678].

See #19647.