I fixed a piece of code that used a hack instead of basename()

[BaylorRae]

Hello I was browsing the source of WordPress wp-admin/includes/theme.php and noticed that it used str_replace() instead of basename().

I've attached my basename-patch.diff file and the updated theme.php file for someone to look over.

---
This is my first time to contribute to WP. I tried to make a commit with SVN but I get a forbidden access error. If you have any suggestions please help.

svn: Commit failed (details follow):
svn: access to '/!svn/act/33767141-9196-41b2-926e-d24cd5f0aa35' forbidden

[BaylorRae]

The SVN diff

[BaylorRae]

Includes my change

[SergeyBiryukov]

basename-patch.diff​ would bring back #10959, see [12253].

[BaylorRae]

Ah, okay. I didn't think about subdirectories.

[Ipstenu]

For the totally unrelated answer.

You can't commit to core. Submit a diff file by attaching it to your trac ticket and, if the gods smile, it will be accepted.