WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

#19661 closed defect (bug) (fixed)

Misleading cursors/indicators when js disabled

Reported by: trepmal Owned by:
Milestone: 3.5 Priority: normal
Severity: normal Version:
Component: UI Keywords: has-patch 3.5-early
Focuses: Cc:

Description

When javascript is disabled, there are still a number of indicators for js-only interactions.

  1. meta boxes still have the 'move' cursor - including post, nav-menus, and widgets screens
  2. meta boxes still have expand/collapse arrow indicator
  3. 'select all' checkbox appears

Patch changes 'move' cursor to default, hides toggle arrow, hides 'select all' checkbox when body has no-js class.

Javascript disabled:

http://cl.ly/CqSh/but-i-cant-toggle.png

Attachments (2)

19661.diff (1.1 KB) - added by trepmal 3 years ago.
19661.2.diff (1.2 KB) - added by JustinSainton 3 years ago.

Download all attachments as: .zip

Change History (10)

@trepmal3 years ago

comment:1 @scribu3 years ago

  • Milestone changed from Awaiting Review to 3.4

comment:3 @nacin3 years ago

The patch looks like it would hide all checkboxes, not just the select all checkbox?

comment:4 @nacin3 years ago

  • Keywords punt added

comment:5 @JustinSainton3 years ago

Good catch, easy enough to add thead to CSS specificity to only target the thead checkbox

Last edited 3 years ago by JustinSainton (previous) (diff)

@JustinSainton3 years ago

comment:6 @nacin3 years ago

  • Keywords 3.5-early added; punt removed
  • Milestone changed from 3.4 to Future Release

comment:8 @helen2 years ago

  • Milestone changed from Future Release to 3.5
  • Resolution set to fixed
  • Status changed from new to closed

Looks like this got taken care of in #21611 and in the 3.5 no-JS audit (#22456). Sorry we missed this ticket.

Note: See TracTickets for help on using tickets.