WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#19668 closed defect (bug) (maybelater)

"Remember Me" checkbox is slightly off in Opera and Chrome

Reported by: SergeyBiryukov Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.3
Component: UI Keywords: has-patch
Focuses: Cc:

Description

See the screenshots. Introduced during CSS merge, [18959] in particular.

The patch makes the checkbox look consistent in Firefox 9, Chrome 16, Opera 11.60, IE 8.

Related: #18740, #19319

Attachments (5)

19668.wp32.png (9.9 KB) - added by SergeyBiryukov 2 years ago.
19668.wp33.png (10.4 KB) - added by SergeyBiryukov 2 years ago.
19668.patch (395 bytes) - added by SergeyBiryukov 2 years ago.
19668.after.png (10.4 KB) - added by SergeyBiryukov 2 years ago.
With 19668.patch
19668.after.2.png (11.2 KB) - added by SergeyBiryukov 2 years ago.

Download all attachments as: .zip

Change History (14)

SergeyBiryukov2 years ago

SergeyBiryukov2 years ago

SergeyBiryukov2 years ago

SergeyBiryukov2 years ago

With 19668.patch

comment:1 nacin2 years ago

  • Keywords commit added

comment:2 SergeyBiryukov2 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Actually, fixed by the changes to input[type="checkbox"] in [20346].

comment:3 helenyhou2 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Although not a part of the ticket by title, the checkbox is still off in Firefox. Patch did fix it there and looked fine in the other browsers.

SergeyBiryukov2 years ago

comment:4 SergeyBiryukov2 years ago

  • Keywords needs-testing added

Hmm. Without the patch, the alignment I see in Firefox 12, Chrome 18, IE 8, Opera 11.62, Safari 5.1.5 is exactly the same as on 19668.after.png (which is fine, I guess).

With the patch, it goes a few pixels up everywhere but Opera (19668.after.2.png).

Last edited 2 years ago by SergeyBiryukov (previous) (diff)

comment:5 helenyhou2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Ahhh, I neglected to check Windows in other browsers. In that case, Firefox on OSX looks like the loner. Will leave this ticket alone :)

comment:6 follow-up: SergeyBiryukov2 years ago

  • Keywords commit needs-testing removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

Some more testing.

Without the patch:

  • Looks good in almost all Windows browsers: Firefox 12, Chrome 18, IE 8, Opera 11.62, Safari 5.1.5. In Chrome 18 and Safari 4.0.3 (OS X) as well.
  • Lower by a few pixels in IE 7 (Windows), Firefox 12 and Opera 11.62 (OS X). Same as the other checkboxes (e.g. on Edit Link screen).

With the current patch:

  • Upper by a few pixels in Windows browsers (Firefox, Chrome, IE 8, Safari). Not bad, and it looked the same way in 3.2, but currently looks better IMO.
  • Good in IE 7 (Windows), Firefox and Opera (OS X).
  • Doesn't make a difference (still good) in Opera (Windows), Chrome and Safari (OS X).

What we have now is less than ideal, but seems like a decent compromise. Would like to revisit at some point later.

comment:7 SergeyBiryukov2 years ago

  • Resolution set to maybelater
  • Status changed from reopened to closed

comment:8 SergeyBiryukov2 years ago

  • Milestone 3.4 deleted

comment:9 in reply to: ↑ 6 azaozz2 years ago

Replying to SergeyBiryukov:

Unfortunately there has always been a "strong disagreement" between the browsers on how vertical-align should work, especially with form elements. All we can do there is compromise.

Note: See TracTickets for help on using tickets.