WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#19670 closed defect (bug) (fixed)

Two notices on wp-signup.php

Reported by: SergeyBiryukov Owned by: ryan
Milestone: 3.4 Priority: normal
Severity: normal Version: 3.0
Component: Multisite Keywords: has-patch
Focuses: Cc:

Description

  1. Go to wp-signup.php.
  2. Select "Just a username, please", but leave "Username" and "Email Address" fields blank.
  3. See the notices:
    Notice: Undefined offset: 0 in wp-includes/ms-functions.php on line 442
    Notice: Undefined index: blog in wp-signup.php on line 260
    

The patch also simplifies checkboxes logic a bit.

Attachments (1)

19670.patch (2.2 KB) - added by SergeyBiryukov 4 years ago.

Download all attachments as: .zip

Change History (4)

@SergeyBiryukov4 years ago

comment:1 @ryan3 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [19850]:

Fix notices. Simplify checkbox logic. Props SergeyBiryukov. fixes #19670

comment:2 @nacin3 years ago

Let's make that preg_match business look a little less, well, bad. $maybe does not need to be set before going into preg_match(), and since we don't care about the results, we can just bring preg_match() inline.

comment:3 @nacin3 years ago

In [19852]:

Simplify matching code. see #19670.

Note: See TracTickets for help on using tickets.