![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 15 years ago
Closed 15 years ago
#19673 closed enhancement (fixed)
Move iPhone CSS from wp-login.php to wp-admin.css
| Reported by: | SergeyBiryukov | Owned by: | azaozz |
|---|---|---|---|
| Priority: | normal | Milestone: | 3.4 |
| Component: | UI | Version: | 2.8 |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: |
Description
There are some iPhone-specific CSS rules in wp-login.php:
http://core.trac.wordpress.org/browser/tags/3.3/wp-login.php#L67
wp-admin.css seems to be a more appropriate place for them.
Attachments (3)
Change History (11)
#2
follow-up:
↓ 5
@
15 years ago
- Cc added
To be honest the whole iPhone check should be replaced to a mobile check. Since a lot of the things also will apply for other OS's like Android. It seems that this code should apply to a certain device width.
#5
in reply to: ↑ 2
@
15 years ago
Replying to markoheijnen:
To be honest the whole iPhone check should be replaced to a mobile check.
Related: http://core.trac.wordpress.org/attachment/ticket/20014/20014-vars.php.patch
It seems that this code should apply to a certain device width.
Yes, most of it but perhaps not making the "action links" that are displayed on hover visible by default.
19673.patch uses
iphoneclass.I've noticed that Toolbar uses
mobile(doesn't seem to be used anywhere else in core though):http://core.trac.wordpress.org/browser/tags/3.3/wp-includes/class-wp-admin-bar.php#L322
Not sure which one is better (
iphonelooks more descriptive), but it would probably make sense to be consistent.