WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#19673 closed enhancement (fixed)

Move iPhone CSS from wp-login.php to wp-admin.css

Reported by: SergeyBiryukov Owned by: azaozz
Milestone: 3.4 Priority: normal
Severity: normal Version: 2.8
Component: UI Keywords: has-patch
Focuses: Cc:

Description

There are some iPhone-specific CSS rules in wp-login.php:
http://core.trac.wordpress.org/browser/tags/3.3/wp-login.php#L67

wp-admin.css seems to be a more appropriate place for them.

Related: #10023, #19331

Attachments (3)

19673.patch (2.7 KB) - added by SergeyBiryukov 6 years ago.
19673.2.patch (3.0 KB) - added by SergeyBiryukov 6 years ago.
19673.3.patch (1.7 KB) - added by SergeyBiryukov 6 years ago.

Download all attachments as: .zip

Change History (11)

#1 @SergeyBiryukov
6 years ago

19673.patch uses iphone class.

I've noticed that Toolbar uses mobile (doesn't seem to be used anywhere else in core though):
http://core.trac.wordpress.org/browser/tags/3.3/wp-includes/class-wp-admin-bar.php#L322

Not sure which one is better (iphone looks more descriptive), but it would probably make sense to be consistent.

#2 follow-up: @markoheijnen
6 years ago

  • Cc marko@… added

To be honest the whole iPhone check should be replaced to a mobile check. Since a lot of the things also will apply for other OS's like Android. It seems that this code should apply to a certain device width.

#3 @nacin
6 years ago

  • Keywords commit added

#4 @nacin
6 years ago

  • Keywords commit removed

#5 in reply to: ↑ 2 @azaozz
6 years ago

Replying to markoheijnen:

To be honest the whole iPhone check should be replaced to a mobile check.

Related: http://core.trac.wordpress.org/attachment/ticket/20014/20014-vars.php.patch

It seems that this code should apply to a certain device width.

Yes, most of it but perhaps not making the "action links" that are displayed on hover visible by default.

#6 @SergeyBiryukov
6 years ago

Refreshed the patch.

#7 @SergeyBiryukov
6 years ago

Refreshed in view of [20417].

#8 @azaozz
6 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In [20430]:

Move mobile devices CSS from wp-login.php to wp-admin.css, props SergeyBiryukov, fixes #19673

Note: See TracTickets for help on using tickets.