WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#19677 closed enhancement (fixed)

Update phpMailer to version 5.2

Reported by: westi Owned by: westi
Milestone: 3.4 Priority: normal
Severity: normal Version: 3.3
Component: External Libraries Keywords: has-patch commit
Focuses: Cc:

Description

PHPMailer development is now in Apache Extras and the current version is 5.2

We should update this and then push any changes we want to recommend upstream

Improvements in 5.2:

  • Adds support for more MIME content types

Attachments (2)

phpmailer-5.2.diff (42.6 KB) - added by westi 2 years ago.
PHP 5.2 for WordPress
19677.diff (566 bytes) - added by MattyRob 2 years ago.

Download all attachments as: .zip

Change History (10)

westi2 years ago

PHP 5.2 for WordPress

comment:1 westi2 years ago

With the update to PHPMailer 5.2 we no longer need any hacks in the Unit Tests to make the code testable so I removed them for WP 3.4 and later in [UT492]

comment:2 westi2 years ago

In [19632]:

Update PHPMailer to version 5.2. See #19677

comment:3 westi2 years ago

Leaving the ticket open in case these changes bring any issues - not expected as they passed all our unit-tests :)

comment:4 follow-up: barry2 years ago

http://core.trac.wordpress.org/browser/trunk/wp-includes/class-phpmailer.php?rev=19632#L760

Looks broken. The - should probably not have been changed to a .

Not sure how the unit-tests passed :)

comment:5 in reply to: ↑ 4 westi2 years ago

Replying to barry:

http://core.trac.wordpress.org/browser/trunk/wp-includes/class-phpmailer.php?rev=19632#L760

Looks broken. The - should probably not have been changed to a .

Not sure how the unit-tests passed :)

Good Catch.

Core WordPress always uses mail() sending not smtp which is why the tests didn't catch this.

MattyRob2 years ago

comment:6 MattyRob2 years ago

  • Keywords has-patch added

Here's a quick patch for the class-smtp.php file name difference. This is how it was implemented in previous versions.

comment:7 SergeyBiryukov2 years ago

  • Keywords commit added

comment:8 ryan2 years ago

  • Resolution set to fixed
  • Status changed from new to closed

In [19642]:

Include class-smtp.php not class.smtp.php. fixes #19677

Note: See TracTickets for help on using tickets.