Add attachment editing filters to Edit Image thickbox view

[kevinlearynet]

Changes made to media attachment fields using the attachment_fields_to_edit and attachment_fields_to_save filters are not added to the Edit Image / Advanced Settings ThickBox view that appears when an existing image is editted in TinyMCE.

Steps to Reproduce:

• Add image to post and save post
• Edit post, and click the 'edit image' icon in order to edit the image while it's in the post

Associated Files

Form fields used for this view are set and processed by these 2 files:

• wp-includes/js/tinymce/plugins/wpeditimage/js/editimage.dev.js
• wp-includes/js/tinymce/plugins/wpeditimage/editimage.html

Unfortunately I can't think of a way to to patch it elegantly.

[nacin]

This is going to be handled by #21390, which is going to kill off this TinyMCE popup.

[rodrigosprimo]

It seems to me that this issue wasn't handled by #21390. Fields added using attachment_fields_to_edit and attachment_fields_to_save filters are still not displayed in the Image Details modal so I'm reopening this ticket.

[helen]

Duplicate of #21390.

@rodrigosprimo The Image Details modal does not edit attachments, but rather manages the details for the image as a part of the HTML content. It's a little confusing, but this is expected behavior. Feel free to respond with more details if I'm missing something, but please don't reopen this ticket since it's specific to the old popup.

[rodrigosprimo]

Thanks for the clarification @helen. I agree that it is a little confusing. Do you know if there is another open ticket to discuss ways to improve this?