Make WordPress Core

Opened 2 years ago

Last modified 2 years ago

#19689 reopened defect (bug)

Context for Dismiss

Reported by: pavelevap Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 3.3
Component: I18N Keywords: has-patch
Focuses: Cc:


In WP 3.3 there are some new occurences for "Dismiss". But in some languages there is not one ideal translation for this verb.

1) Dismiss - meaning Close (suitable for Welcome screen, Browser window and Pointers).

2) Dismiss - meaning Cancel or Stop (suitable for uploading media).

I created basic patch to better explain this idea.

I also could not find occurences for Dismiss in async-upload.php and script-loader.php anywhere in administration during upload, but maybe it is related to some special conditions? In which circumstances can users see string Dismiss during uploading media?

Attachments (2)

dismiss_context.patch (3.3 KB) - added by pavelevap 2 years ago.
19689.patch (3.3 KB) - added by SergeyBiryukov 2 years ago.

Download all attachments as: .zip

Change History (13)

pavelevap2 years ago

comment:1 ocean902 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 3.4


comment:2 pavelevap2 years ago

It looks that the second context in script-loader.php should be also "Close info window". It is probaly small link displayed to close some upload error messages...

So, the only context should be changed in async-upload.php, but I did not find a way to simulate "Dismiss" message here...

comment:3 nacin2 years ago

There are a number of contexts here. How exactly should they be split?

  1. "Dismiss" to hide an inline error message (async-upload.php, and the second one in script-loader.php)
  2. "Dismiss" to hide a boxed area (dashboard.php, both instances — Browse Happy and the Welcome panel)
  3. "Dismiss" to close a pointer (the first one in script-loader.php)

The contexts for the first bullet point are "Cancel upload" (per the patch) and the second and third points are "Close window" (per the patch). Is there a difference between what is occurring in points 2 and 3? To me, I'd think that point 2 is aligned with point 1, not point 3.

comment:4 pavelevap2 years ago

Yes, I was not sure about upload related strings. I thought that "Dismiss" in this context is for "Cancel upload". But if it is related to closing error message, then better solution is from nacin.

But for our language is Hide and Close similar, so in the end this change is not required, sorry for bothering you. But maybe for other languages it would be helpful, I am not sure... Sometimes it can be used shorter translation for inline error message and longer (more accurate) for hiding boxed area, for example. Also in English are Close and Hide very similar (close pointer to hide it).

comment:5 nacin2 years ago

  • Milestone 3.4 deleted
  • Resolution set to wontfix
  • Status changed from new to closed

As all five of them do indeed mean "Hide notice", then let's close this as wontfix.

ocean90, if you see a context that will help German or other languages, we can re-evaluate.

comment:6 pavelevap2 years ago

Maybe it could be usefull to separate two meanings:

  • "Close" as definitively closing box or message.
  • "Hide" as hiding box, which can be unhide later.

comment:7 nacin2 years ago

  • Resolution wontfix deleted
  • Status changed from closed to reopened

comment:8 nacin2 years ago

  • Milestone set to 3.4

SergeyBiryukov2 years ago

comment:9 SergeyBiryukov2 years ago

19689.patch is an attempt to split the strings according to comment:6.

For ru_RU, it's still the same meaning in these contexts though. Perhaps for some other language it would make a difference.

comment:10 nacin2 years ago

Perhaps it is worth waiting until a language actually requires these contexts, as the contexts don't really make things any more clear. Sergey, do you want to make a post on wppolyglots?

comment:11 nacin2 years ago

  • Milestone changed from 3.4 to Awaiting Review
Note: See TracTickets for help on using tickets.