WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#19726 closed enhancement (fixed)

Don't update the post_thumbnail_cache if the thumbnail is already cached

Reported by: prettyboymp Owned by:
Milestone: 3.4 Priority: normal
Severity: normal Version: 3.3
Component: Performance Keywords: has-patch needs-testing
Focuses: Cc:

Description

There is no reason to run the query in update_post_thumbnail_cache() if all of the thumbnail posts are already cached. Before adding a post_id to the thumb_ids array, cache should be checked.

Attachments (1)

19726.diff (682 bytes) - added by prettyboymp 2 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 nacin2 years ago

  • Milestone changed from Awaiting Review to 3.4

Nice.

prettyboymp2 years ago

comment:2 prettyboymp2 years ago

The attachment also fixes a bug where the update_post_thumbnail_cache() actually doesn't help anything when running object cache since the wp_query param cache_results defaults to false if you're running object cache.

comment:3 prettyboymp2 years ago

  • Keywords has-patch needs-testing added

comment:4 duck_2 years ago

  • Resolution set to fixed
  • Status changed from new to closed

[19918] should do the trick.

Note: See TracTickets for help on using tickets.