WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#19731 closed defect (bug) (duplicate)

File Listing Error and Selection Box Error on Plugin Editor

Reported by: midhund Owned by: midhund
Milestone: Priority: normal
Severity: normal Version: 3.3
Component: Plugins Keywords: has-patch
Focuses: Cc:

Description

  1. File Listing Error When I choose a plugin from the dropdown box to edit, all file will listed out at the right hand side. Suppose the plugin have sub folder in it, all files will be listed there but when we choose a file ie from the sub-folder to edit, then the list shows only the files from that sub-folder.

So the navigation is not that easy, we need to use select box again to show all files.

see attached image.

  1. "Selected" property of Plugin Select Box is incorrect. It works only when we chose the selected plugin's main file.

see the image : I choose the file from 'wp-notify' plugin and the select box show 'akismet'

I have fixed that issue, and attached the Patch file.

Attachments (4)

list-shows-onlyfiles-from-admin-folder.JPG (9.6 KB) - added by midhund 2 years ago.
list showing only files from admin folder
plugins-files-list.JPG (27.0 KB) - added by midhund 2 years ago.
Listing Files from a selected plugin
After-my-fix.JPG (16.4 KB) - added by midhund 2 years ago.
Listing all files after applying my fix
plugin-editor-file-listing-bugfix.patch (471 bytes) - added by midhund 2 years ago.
Patch File

Download all attachments as: .zip

Change History (7)

midhund2 years ago

list showing only files from admin folder

midhund2 years ago

Listing Files from a selected plugin

comment:1 follow-up: dd322 years ago

"Selected" property of Plugin Select Box is incorrect. It works only when we chose the selected plugin's main file.

I believe that part might be related to the issues in #17552

midhund2 years ago

Listing all files after applying my fix

midhund2 years ago

Patch File

comment:2 in reply to: ↑ 1 midhund2 years ago

Replying to dd32:

"Selected" property of Plugin Select Box is incorrect. It works only when we chose the selected plugin's main file.

I believe that part might be related to the issues in #17552

my patch fixed two problems I mentioned above.

comment:3 ocean902 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to duplicate
  • Status changed from new to closed

First point: #17281, #10429, #14175, #6531

Second point: #17552

Note: See TracTickets for help on using tickets.