WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#19734 closed defect (bug) (wontfix)

Default theme (twentyeleven) missing styles for select

Reported by: skylarsutton Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

The default theme (twentyeleven) styles all input fields / text areas but doesn't apply anything to selects. This creates an inconsistent look and feel.

I've included the manually tweaked version of my styles.css which fixed the issue for me.

Attachments (2)

styles.css (55.5 KB) - added by skylarsutton 3 years ago.
Possible patch
19734.diff (1.1 KB) - added by DrewAPicture 3 years ago.
props skylarsutton

Download all attachments as: .zip

Change History (10)

@skylarsutton3 years ago

Possible patch

comment:1 @SergeyBiryukov3 years ago

  • Component changed from Themes to Bundled Theme
  • Keywords needs-patch added; has-patch removed

Please add a real a diff/patch file, see http://codex.wordpress.org/Reporting_Bugs#Patching_Bugs.

@DrewAPicture3 years ago

props skylarsutton

comment:2 @DrewAPicture3 years ago

  • Keywords has-patch added; needs-patch removed

comment:3 @lancewillett3 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

I think it's better to leave select styling to browsers so that the native OS look and feel comes through for this form element.

comment:4 follow-ups: @skylarsutton3 years ago

a) Have you seen it? It looks awful.

b) The same argument could be made for all form elements. Why are you styling input and textarea... those should be "native" as well.

comment:5 in reply to: ↑ 4 @lancewillett3 years ago

Replying to skylarsutton:

a) Have you seen it? It looks awful.

Every day. :) I use it extensively for my main blogs and have several child themes and customizations.

In my opinion if you feel really strongly about styling extra from elements go for it -- it'd be a great fit for custom CSS in your fork of the theme or child theme.

comment:6 follow-up: @skylarsutton3 years ago

My first comment was some humor, not an attack.

My real issue is the justification. Why style some form elements and not others? It creates a disjointed final product. The end user expectation is that they slap the style down as a turn key product and everything looks puuurty. The average user isn't going to know/care enough about CSS to hunt down unstyled elements and customize them.

comment:7 in reply to: ↑ 6 @lancewillett3 years ago

Replying to skylarsutton:

My real issue is the justification. Why style some form elements and not others? It creates a disjointed final product. The end user expectation is that they slap the style down as a turn key product and everything looks puuurty. The average user isn't going to know/care enough about CSS to hunt down unstyled elements and customize them.

No worries, and thanks again for your thoughts.

comment:8 in reply to: ↑ 4 @nacin3 years ago

Replying to skylarsutton:

a) Have you seen it? It looks awful.

A screenshot could go a long way to justify something like this.

Note: See TracTickets for help on using tickets.