WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#19746 closed defect (bug) (fixed)

Reference to _help_sidebar in WP_Screen (wp-admin/includes/screen.php)

Reported by: jgilje Owned by:
Milestone: 3.4 Priority: normal
Severity: normal Version: 3.3.1
Component: General Keywords: has-patch
Focuses: Cc:

Description

I'm running WordPress under Quercus, and it fails to run the admin page. I narrowed the cause of the error down to how the _help_sidebar variable is accessed inside the WP_Screen class.

I'm attaching a patch which will correct the issue for Quercus and still work for the main PHP-interpreter.

Attachments (1)

wp.patch (202 bytes) - added by jgilje 3 years ago.

Download all attachments as: .zip

Change History (5)

@jgilje3 years ago

comment:1 @dd323 years ago

  • Milestone changed from Awaiting Review to 3.4
  • Resolution set to fixed
  • Status changed from new to closed

Let me guess, PHP 5.2?

It's been caught and fixed already though: [19680]

comment:2 @ocean903 years ago

Something for 3.3.2?

comment:3 @dd323 years ago

Something for 3.3.2?

I didn't realise, but Quercus is a PHP Implementation in Java, so it's not a PHP 5.2 thing. If it was a PHP5.2 issue, I'd expect many more broken sites, as every admin view would be fataling. Not sure it needs a backport, but doesn't do any harm either. I'll leave it up to nacin to decide what to do there :)

comment:4 @nacin3 years ago

I never saw this ticket; we probably should have backported this, but it is too late now.

Note: See TracTickets for help on using tickets.