Bad error message: "An error occurred while updating PLUGIN: The plugin is at the latest version.."

[markjaquith]

This error message is poor:

"An error occurred while updating PLUGIN: The plugin is at the latest version.."

It has a red background and everything.

We should just succeed with a note that it was already up to date. Failures are for things that went wrong, not that already went right.

[solarissmoke]

Just to add, this only happens with the bulk upgrader. For individual upgrades it just reports that the plugin is already up to date.

Attached is a patch that reports an already up to date plugin/theme as a success (instead of an error). The "plugin is at the latest version" bit then appears under "show details". The current code doesn't really allow for a neutral message, it has to be either success or error, and success seems more appropriate.

[nacin]

Looks good.

[nacin]

Would like to test this out to see what it looks like, but otherwise good to go.

[dd32]

Patch looks good to me too, For reference, here's a ​before and ​after shot.

[markjaquith]

In [21236]:

Do not display an error message when a plugin or theme being updated is found to already be up to date. Note the fact, and call it success. props solarissmoke. fixes #19752