Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#19752 closed enhancement (fixed)

Bad error message: "An error occurred while updating PLUGIN: The plugin is at the latest version.."

Reported by: markjaquith Owned by: markjaquith
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.3.1
Component: Plugins Keywords: has-patch commit
Focuses: Cc:


This error message is poor:

"An error occurred while updating PLUGIN: The plugin is at the latest version.."

It has a red background and everything.

We should just succeed with a note that it was already up to date. Failures are for things that went wrong, not that already went right.

Attachments (1)

19752.diff (1.1 KB) - added by solarissmoke 6 years ago.

Download all attachments as: .zip

Change History (6)

#1 @solarissmoke
6 years ago

  • Keywords has-patch dev-feedback added

Just to add, this only happens with the bulk upgrader. For individual upgrades it just reports that the plugin is already up to date.

Attached is a patch that reports an already up to date plugin/theme as a success (instead of an error). The "plugin is at the latest version" bit then appears under "show details". The current code doesn't really allow for a neutral message, it has to be either success or error, and success seems more appropriate.

6 years ago

#2 @nacin
6 years ago

  • Milestone changed from Awaiting Review to 3.5

Looks good.

#3 @nacin
6 years ago

  • Keywords commit added; dev-feedback removed

Would like to test this out to see what it looks like, but otherwise good to go.

#4 @dd32
6 years ago

Patch looks good to me too, For reference, here's a before and after shot.

#5 @markjaquith
6 years ago

  • Owner set to markjaquith
  • Resolution set to fixed
  • Status changed from new to closed

In [21236]:

Do not display an error message when a plugin or theme being updated is found to already be up to date. Note the fact, and call it success. props solarissmoke. fixes #19752

Note: See TracTickets for help on using tickets.