Quotes in post title make it into the title for comments_popup_link()

[Viper007Bond]

If you have a post with quotes in it, they make it into the title for the comments_popup_link() link. This makes invalid code.

Example:

Post title = Announcing "Alphabetical Plugins"

Then this code:

comments_popup_link('Comments Off', '1 Comment »', '% Comments »');

produces:

<a href="http://www.viper007bond.com/archives/2005/11/27/announcing-alphabetical-plugins/#respond" title="Comment on Announcing "Alphabetical Plugins"">Comments Off</a>

Solution: htmlspecialchars() or wp_texturize() needs to be run on the post title before it's used.

[abhay]

wraps wptexturize() around $post_title

[abhay]

Since you didn't attach the diff file yourself, I just did it for ya. Props to you for solution.

[Viper007Bond]

Much appreciated. :) I don't have any SVN software or anything to make a diff file with, so... :/

[Viper007Bond]

Not sure if wp_texturize() or htmlspecialchars() is the preferred thing for this BTW.

[markjaquith]

My patch uses wp_specialchars()

[Viper007Bond]

Yeah, that's best.

When I wrote this over 3 months ago, I wasn't aware of how to create patches and the function wp_specialchars(). I was such a noob. :D

[metallman]

wp_specialchars needs to be called with a true second argument to actually replace quotes. Like this wp_specialchars($post->post_title, 1).

If this change is done to the patch, it works for me.

[thetorpedodog]

I've got a different patch on ticket #2625 that uses applying the filters for the_title. It does all the fancy quote and dash nonsense and other things applied to post_title().

[Viper007Bond]

Fixed via #2915 (about time!)