WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #19780, comment 5


Ignore:
Timestamp:
12/12/12 16:54:09 (16 months ago)
Author:
Offereins
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #19780, comment 5

    initial v1  
    1 I'd prefer this rewrite to taxonomy-agnostic behaviour to be more complete. Therefor also the filters (like `list_cats`, `wp_list_cats`, `wp_dropdown_cats`) and the filters in the Walker classes should be rewritten to a taxonomy-agnostic style. Additionally the `list_cats` filter in the Walker classes would do great when sending the `$args` variable as third parameter. 
     1I'd prefer this rewrite to taxonomy-agnostic behaviour to be more complete. Therefor also the filters (like `list_cats`, `wp_list_cats`, `wp_dropdown_cats`) and the filters in the Walker classes should be rewritten to a taxonomy-agnostic style. Additionally 1) the `list_cats` filter in the Walker classes would do great when sending the `$args` variable as third parameter and 2) we might not wrap each list item with an `<a>` tag by default; I could think of use cases where I would want to set a custom `href` attribute on it or don't use an `<a>` tag at all (@see `Walker_Category::start_el()`). 
    22 
    33Concerning the `wp_dropdown_terms` and `wp_list_terms` solutions, I'd say they'd be better off the other way around, as the base of the `category` functions instead of the wrapper type like it's suggested in 19780.diff. This would result in `wp_dropdown_categories` being a wrapper for `wp_dropdown_terms` etc.