WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 2 years ago

#19781 closed defect (bug) (wontfix)

All update processes should be within an iframe

Reported by: dd32 Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords: has-patch needs-refresh shiny-updates
Focuses: Cc:

Description (last modified by dd32)

Currently some of the update processes run within iframes, others don't.

We should standardise on all within an iframe.

Running inside the iframe has the advantage that the footer of the page is loaded, and therefor, the Toolbar will load, rather than the page appearing half-loaded for certain upgrade/install processes.

Currently, Processes which run inside iframes are Bulk updates, Singular updates load directly.

We should also investigate a iframe overlay that contains a "Working.. please wait" graphic that clears once the content of the iframe starts loading, This should help ease the pain of not being sure if the update process has started on servers that force gzip (and as a result, provide no user feedback until the process is complete) - See #18525 and #18239 for examlples of that see #19783

Attachments (1)

19781.diff (4.6 KB) - added by dd32 6 years ago.

Download all attachments as: .zip

Change History (12)

#1 @dd32
6 years ago

  • Description modified (diff)

#2 @DrewAPicture
6 years ago

  • Cc xoodrew@… added

+1 for this. I've experienced the "updates hang" issue on many installs. I wasn't aware that some were iframed and others weren't.

#3 @dd32
6 years ago

  • Description modified (diff)

#4 @kawauso
6 years ago

  • Cc kawauso added

#5 @dd32
6 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to Future Release

iframe'd:

  • Bulk Upgrade Theme/Plugins

non-iframe:

  • Theme/Plugin upgrade - Singular, non-bulk upgrade (ie. "Update Automatically" was clicked)
  • Theme/Plugin Install - from Web
  • Theme/Plugin Install - from uploaded Zip

Quick attachment adds Iframe'ing to Singular plugin upgrades, and to singular Theme upgrades. Theme upgrades however have a problem as they include a Preview link (Which I personally think we should just remove). Thoughts on Themes?

@dd32
6 years ago

#6 @dd32
6 years ago

A future iteration can remove the singular upgrade code and roll single updates through the bulk handler.

#8 @chriscct7
3 years ago

  • Keywords needs-refresh added

#9 @dd32
3 years ago

This is mostly rendered invalid by Ajax "smooth updates" going forward.

#10 @ocean90
2 years ago

  • Keywords shiny-updates added

#11 @obenland
2 years ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Wontfix based on the new UI directions that we've taken with shiny updates v1 and v2 in [37714].

Note: See TracTickets for help on using tickets.