WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#19785 closed enhancement (fixed)

Uploaded Media Delete Confirm Buttons Not Aligned

Reported by: JarretC Owned by: markjaquith
Milestone: 3.4 Priority: normal
Severity: normal Version: 3.0
Component: UI Keywords: has-patch commit
Focuses: Cc:

Description

After uploading the media but before saving your changes if you choose to delete the file the Continue/Cancel buttons end up on a different line.

Just a small patch that adds a paragraph element around the buttons to add them onto the next line. This also spaces the Cancel button a little bit further away from the filename so that it isn't so close.

Attachments (8)

old_new.jpg (10.5 KB) - added by JarretC 3 years ago.
delete-confirm.patch (1.4 KB) - added by JarretC 3 years ago.
19785.delete-confirm.png (7.3 KB) - added by SergeyBiryukov 3 years ago.
With delete-confirm.patch
19785.patch (1.6 KB) - added by SergeyBiryukov 3 years ago.
19785.after.png (15.2 KB) - added by SergeyBiryukov 3 years ago.
With 19785.patch
delete-confirm-2.patch (1.8 KB) - added by JarretC 3 years ago.
19785.2.patch (1.4 KB) - added by lancewillett 3 years ago.
Clean up patch to remove CSS, just add the block-level element
19785.diff (1.3 KB) - added by aaroncampbell 3 years ago.

Download all attachments as: .zip

Change History (19)

@JarretC3 years ago

@JarretC3 years ago

comment:1 @linuxologos3 years ago

  • Version changed from 3.3.1 to 3.0

comment:2 @DrewAPicture3 years ago

Looks like an improvement. +1

comment:3 @jane3 years ago

  • Keywords ui-feedback removed
  • Milestone changed from Awaiting Review to 3.4

I'm down.

@SergeyBiryukov3 years ago

With delete-confirm.patch

@SergeyBiryukov3 years ago

@SergeyBiryukov3 years ago

With 19785.patch

comment:4 follow-up: @SergeyBiryukov3 years ago

One minor concern is that a <p> tag would take up a bit more space and mouse movement for short file names (see 19785.delete-confirm.png).

19785.patch moves the buttons to the next line for long file names only (see 19785.after.png).

comment:5 in reply to: ↑ 4 @JarretC3 years ago

Replying to SergeyBiryukov:

One minor concern is that a <p> tag would take up a bit more space and mouse movement for short file names (see 19785.delete-confirm.png).

19785.patch moves the buttons to the next line for long file names only (see 19785.after.png).

True, I was just initially thinking that having it always under would provide a consistent place in the UI as it would never change, even though it is a minor change.

I agree with the spacing, was going to add a class to the <p> and shorten the space with CSS but was just wanting to get an initial response.

comment:6 @nacin3 years ago

I would opt for a consistent location. Let's figure out the padding and commit this.

@JarretC3 years ago

comment:7 @JarretC3 years ago

Added in new patch with CSS class and CSS updates, put them in media-dev.css...not 100% sure if it is supposed to go there or not. If not, let me know!

http://core.trac.wordpress.org/attachment/ticket/19785/delete-confirm-2.patch

comment:8 @lancewillett3 years ago

  • Keywords dev-feedback needs-testing added

@lancewillett3 years ago

Clean up patch to remove CSS, just add the block-level element

comment:9 @aaroncampbell3 years ago

  • Cc aaroncampbell added

I think adding the paragraph tag around the text instead of the images make more sense.

@aaroncampbell3 years ago

comment:10 @aaroncampbell3 years ago

  • Keywords commit added; dev-feedback needs-testing removed

Talked to Lance and decided that it did make more sense to put the paragraph tag around the text instead of the buttons. It has the same effect and it's more semantic. 19785.diff does just that.

comment:11 @markjaquith3 years ago

  • Owner set to markjaquith
  • Resolution set to fixed
  • Status changed from new to closed

In [20309]:

Wrap attachment delete link in <p> for semantics and alignment. props aaroncampbell, lancewillett. fixes #19785

Note: See TracTickets for help on using tickets.