WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

#19787 closed enhancement (fixed)

Improve theme activated message

Reported by: iamronen Owned by: nacin
Milestone: 3.5 Priority: normal
Severity: minor Version: 3.3.1
Component: UI Keywords: has-patch
Focuses: Cc:

Description

This suggestion is in regard to the new widget-restoration feature. The new "tip" that appears can be confusing and is redundant. My sample scenario - I was (still am) having a problem with the media uploader and activated twenty-eleven to see if it was a theme issue.

Then the "tip" appeared together with the theme activation message: "New theme activated. This theme supports widgets, please visit the widgets settings screen to configure them."

The combination of the two led me to think that the new theme "supports widget restoration" and that for some reason my custom theme (the one I was switching away from) did not. Confusing.

If a theme is activated and has saved widget settings why not just add that to the message "This theme supports widgets and previous widgets have been restored, please visit the widgets settings screen to onfigure them"?

In this case the "tip" feels more like wanting to show off a new feature then clearly communicating what has happened.

Attachments (2)

19787_optionb.diff (1.3 KB) - added by ryanimel 3 years ago.
Implementing option B, also adding a missing period to the message.
19787_optionb-2.diff (1.3 KB) - added by lessbloat 3 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 @SergeyBiryukov3 years ago

  • Keywords ux-feedback added

comment:2 @nacin3 years ago

  • Component changed from Themes to UI
  • Milestone changed from Awaiting Review to 3.5

If a theme is activated and has saved widget settings why not just add that to the message "This theme supports widgets and previous widgets have been restored, please visit the widgets settings screen to onfigure them"?

I like this.

At the same time, it would be nice to eliminate the comma splice.

comment:3 @lessbloat3 years ago

Hmm... Given the choice between:

A) "New theme activated. This theme supports widgets, please visit the widgets settings screen to configure them.", and

B) "New theme activated. Visit site"

I think I'd choose option B (whether widgets are available or not). Visiting my site to check out what my new theme looks like would almost always be the first thing I'd want to do.

comment:4 @nacin3 years ago

I think I'd choose option B (whether widgets are available or not). Visiting my site to check out what my new theme looks like would almost always be the first thing I'd want to do.

I would tend to agree.

comment:5 @iamronen3 years ago

Amen.

Widgets settings are "obivously" (as it should be) saved and restored ... so no need to say it.

Maybe next time there is no need to "show off" a new feature?

@ryanimel3 years ago

Implementing option B, also adding a missing period to the message.

comment:6 follow-up: @ryanimel3 years ago

  • Keywords has-patch added

In case option B is the direction we want to go here, I attached a patch that will do that. I also added back a missing period to the "New theme activated. Visit site." message.

comment:7 @lessbloat3 years ago

  • Keywords ux-feedback removed

19787_optionb.diff looks good to me.

comment:8 in reply to: ↑ 6 @SergeyBiryukov3 years ago

Replying to ryanimel:

I also added back a missing period to the "New theme activated. Visit site." message.

Not sure about that part. Seems inconsistent with similar messages ("Post updated. View post" or "New user created. Edit user"), which don't have a period:
http://core.trac.wordpress.org/browser/tags/3.4.1/wp-admin/edit-form-advanced.php#L35
http://core.trac.wordpress.org/browser/tags/3.4.1/wp-admin/users.php#L354

Perhaps removing the period from line 111 would be better.

@lessbloat3 years ago

comment:9 @lessbloat3 years ago

Removed periods in 19787_optionb-2.diff

comment:10 @nacin2 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [21972]:

Remove "This theme supports widgets..." from the theme activation notice. props ryanimel. fixes #19787.

Note: See TracTickets for help on using tickets.